search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 918 forks source link

For getting version from package.json we are exporting entire package.json. #462

Open santoshyadavdev opened 5 years ago

santoshyadavdev commented 5 years ago

Describe the feature you'd like:

Do not export entire package.json to get the version. It becomes the part of build,

Other information:

I would be willing to submit a PR to fix this issue:

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

tomastrajan commented 5 years ago

@santoshyadav198613 any ideas on how to improve the current solution ?

santoshyadavdev commented 5 years ago

Hi @tomastrajan , I will raise a PR sorry I forgot to do this.

I am traveling now, will raise in this weekend.

tomastrajan commented 5 years ago

@santoshyadav198613 no worries ;) and than you!

santoshyadavdev commented 5 years ago

Hi @tomastrajan , Check if the approach is fine, i am writing only the packages required to a version.json and than using it, so we can avoid exporting entire package.json