tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 918 forks source link

refactor(path aliases): add core, shared and environments path aliases #469

Closed alharto closed 5 years ago

alharto commented 5 years ago

Updated the root tsconfig.json with 3 path aliases (shared, core and environments). Also updated several import paths to use said aliases as this makes refactoring the project structure easier.

codecov-io commented 5 years ago

Codecov Report

Merging #469 into master will decrease coverage by 0.39%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #469     +/-   ##
=========================================
- Coverage   72.96%   72.56%   -0.4%     
=========================================
  Files          59       59             
  Lines         503      503             
  Branches       41       41             
=========================================
- Hits          367      365      -2     
- Misses        127      129      +2     
  Partials        9        9
Impacted Files Coverage Δ
src/app/core/core.state.ts 62.5% <ø> (ø) :arrow_up:
...otifications/components/notifications.component.ts 37.5% <ø> (ø) :arrow_up:
...atures/examples/theming/parent/parent.component.ts 100% <ø> (ø) :arrow_up:
src/app/core/settings/settings.model.ts 100% <ø> (ø) :arrow_up:
src/app/features/examples/form/form.effects.ts 100% <ø> (ø) :arrow_up:
...ket/components/stock-market-container.component.ts 100% <ø> (ø) :arrow_up:
src/app/core/meta-reducers/debug.reducer.ts 0% <ø> (ø) :arrow_up:
src/app/app/app.component.ts 50% <ø> (ø) :arrow_up:
src/app/features/examples/crud/books.selectors.ts 85.71% <ø> (ø) :arrow_up:
src/app/features/examples/crud/books.effects.ts 100% <ø> (ø) :arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35f3160...c3e7c14. Read the comment docs.

tomastrajan commented 5 years ago

We don't want this even though is nice but currently not supported by StackBlitz so yeah... Anyway thanks very much for your contribution and hope you enjoy the starter!