search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

Use the NgRx 8 `create` factory functions #472

Closed timdeschryver closed 5 years ago

timdeschryver commented 5 years ago

Describe the feature you'd like:

The release of NgRx 8 gave us a way to define actions and reducers in a less verbose way with createAction and createReducer. I would like to see this project to use these functions and the new createEffect.

Other information:

I tried to list all of the features using NgRx here below. Feel free to claim your own feature 🙂

We're here to guide you along the way. (I will probably pick one feature in a couple of days, to get this started)

tomastrajan commented 5 years ago

Also, here is a great blog post detailing how to do it in practice ! https://offering.solutions/blog/articles/2019/07/01/updating-your-angular-app-to-ngrx-8/

geromegrignon commented 5 years ago

I'll work on CRUD part tonight.

tomastrajan commented 5 years ago

@geromegrigon great, thanks ! 🔥

timdeschryver commented 5 years ago

@evgenyfedorenko do you want to pick one up? Please don't feel obligated

evgenyfedorenko commented 5 years ago

@timdeschryver a bit slammed at the moment with other stuff. I will certainly consider doing it later.

timdeschryver commented 5 years ago

Sure, feel free to check in at any point 🙂

santoshyadavdev commented 5 years ago

Hi @timdeschryver , I can take few, let me know which part i can work on.

timdeschryver commented 5 years ago

I was just about to pick up Auth myself, feel free to claim your own @santoshyadav198613

santoshyadavdev commented 5 years ago

Cool @timdeschryver , working on one very old issue, as soon as it is done, will pickup Todos.

santoshyadavdev commented 5 years ago

I am taking Form next.

tomastrajan commented 5 years ago

@timdeschryver this is coming together in a very nice speed ! Amazing community work!

geromegrignon commented 5 years ago

@abedzantout thanks for your contribution but for furthers contributions you should communicate about your contribution to avoid people working both on the same part. @santoshyadav198613 : Form part has been merged fyi.

santoshyadavdev commented 5 years ago

Cool @geromegrignon , in that case taking settings.

abedzantout commented 5 years ago

@geromegrignon i’ll Be working on updating the settings also. Should be done soon.

@santoshyadav want to help me with the tests ?

santoshyadavdev commented 5 years ago

@geromegrignon i’ll Be working on updating the settings also. Should be done soon.

@santoshyadav want to help me with the tests ?

Oops i was already done with actions and effects, never mind please update before you start working to avoid rework.

Sure push the changes i will take care of test cases.

abedzantout commented 5 years ago

@santoshyadav198613 Please check PR

timdeschryver commented 5 years ago

It seems like we have everything covered, thanks for your help! 🙌

tomastrajan commented 5 years ago

Thanks for the epic contributions peeps ! 👍