search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 918 forks source link

fix(chore): take only version which is required #474

Closed santoshyadavdev closed 4 years ago

santoshyadavdev commented 5 years ago

What:

Issue number: #462

codecov-io commented 5 years ago

Codecov Report

Merging #474 into master will decrease coverage by 0.34%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   73.97%   73.63%   -0.35%     
==========================================
  Files          64       64              
  Lines         588      588              
  Branches       46       46              
==========================================
- Hits          435      433       -2     
- Misses        142      144       +2     
  Partials       11       11
Impacted Files Coverage Δ
...x-material-starter/src/environments/environment.ts 100% <ø> (ø) :arrow_up:
...tarter/src/app/core/animations/route.animations.ts 70% <0%> (-20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c562759...80c0b0b. Read the comment docs.

tomastrajan commented 5 years ago

Hi @santoshyadav198613 ! Thanks for your contribution!

The thing is I would love to keep number of dependencies / technologies as low as possible... This is for various reasons but mostly because it is a starter it should be as simple as possible and adding yet another build tool complicates things and can be confusing for the beginners...

Could this be achieved using npm scripts and maybe some inline / npx script or something inside of the environment.ts file itself?

santoshyadavdev commented 5 years ago

Hi @santoshyadav198613 ! Thanks for your contribution!

The thing is I would love to keep number of dependencies / technologies as low as possible... This is for various reasons but mostly because it is a starter it should be as simple as possible and adding yet another build tool complicates things and can be confusing for the beginners...

Could this be achieved using npm scripts and maybe some inline / npx script or something inside of the environment.ts file itself?

Yes, sure I will look for alternatives as well, as this was the first approach I had in my mind.