search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

feat: ngrx 8 refactor #477

Closed abedzantout closed 5 years ago

abedzantout commented 5 years ago

What:

Issue number: https://github.com/tomastrajan/angular-ngrx-material-starter/issues/472

Integrated the new features of Ngrx 7 into the examples folder. Effects, reducers as well as actions were refactored to accommodate for the new changes.

codecov-io commented 5 years ago

Codecov Report

Merging #477 into master will decrease coverage by 0.46%. The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   73.43%   72.96%   -0.47%     
==========================================
  Files          64       64              
  Lines         576      566      -10     
  Branches       42       36       -6     
==========================================
- Hits          423      413      -10     
  Misses        143      143              
  Partials       10       10
Impacted Files Coverage Δ
...eatures/examples/crud/components/crud.component.ts 32.14% <0%> (ø) :arrow_up:
...er/src/app/features/examples/crud/books.actions.ts 100% <100%> (ø) :arrow_up:
...ter/src/app/features/examples/form/form.reducer.ts 100% <100%> (ø) :arrow_up:
...er/src/app/features/examples/crud/books.effects.ts 100% <100%> (ø) :arrow_up:
...ures/examples/stock-market/stock-market.reducer.ts 100% <100%> (ø) :arrow_up:
...ket/components/stock-market-container.component.ts 100% <100%> (ø) :arrow_up:
...er/src/app/features/examples/crud/books.reducer.ts 100% <100%> (ø) :arrow_up:
...ures/examples/stock-market/stock-market.actions.ts 100% <100%> (ø) :arrow_up:
...ter/src/app/features/examples/form/form.effects.ts 100% <100%> (ø) :arrow_up:
...ter/src/app/features/examples/form/form.actions.ts 100% <100%> (ø) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5edcb3...54272f8. Read the comment docs.

tomastrajan commented 5 years ago

Wow ! Thanks for epic PR @abedzantout !