tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

fix(change-hours): run change hours interval outside of angular zone #516

Closed dvargas46 closed 4 years ago

dvargas46 commented 4 years ago

What: Updated change hours effect interval to run outside of Angular zone. This should fix the testability not stabilizing issue without affecting the nature of the effect (to adjust the theme upon app load based on current time).

Closes #511

Issue number: #511

codecov-io commented 4 years ago

Codecov Report

Merging #516 into master will decrease coverage by 0.39%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #516     +/-   ##
=========================================
- Coverage    70.1%   69.71%   -0.4%     
=========================================
  Files          65       65             
  Lines         552      558      +6     
  Branches       34       35      +1     
=========================================
+ Hits          387      389      +2     
- Misses        157      161      +4     
  Partials        8        8
Impacted Files Coverage Δ
...-starter/src/app/core/settings/settings.effects.ts 60.97% <40%> (-7.6%) :arrow_down:
...eatures/examples/form/components/form.component.ts 76.19% <0%> (+4.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8de0587...74ece30. Read the comment docs.

tomastrajan commented 4 years ago

@dvargas46 thanks for your contribution!