search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

fix(form): replace pass in storage stop duplicate requests from form … #559

Closed millbj92 closed 2 years ago

millbj92 commented 2 years ago

…state, closes #527, closes #558

What:

After reading issue #527 I started looking at the state a little more and realized they were indeed right, so I fixed that. I also discovered that the password value is not being omitted or masked in state or local storage. State isn't such a big deal, but localStorage would be a security concern. I chose not to go with hashing and salting as I don't want to bloat this package with another library. May want to put a small sidenote on the form that more work needs to be done for it to be used in an actual production scenario. Cheers!

Issue number: #527 Issue number: #558

tomastrajan commented 2 years ago

hi @millbj92 would love to merge if there were no conflicts ;)

tomastrajan commented 2 years ago

Hi @millbj92 , any update on this ? :D THank you!

millbj92 commented 2 years ago

oof, I've been super busy! I'll get to this ASAP!

millbj92 commented 2 years ago

@tomastrajan I went ahead and got it done. Build seems to be breaking though. Looks like CI is having trouble installing chrome? Not sure it's anything I'd be able to help with. Requeuing may solve.

tomastrajan commented 2 years ago

@millbj92 thank you, gonna have a look 👍

tomastrajan commented 2 years ago

@millbj92 looks like a problem in package.json / package-lock.json as it happens during npm ci and npm ERR! Unexpected token < in JSON at position 45

tomastrajan commented 2 years ago

But gonna merge and fix on master, thank you!

millbj92 commented 2 years ago

Bah, I forgot. This is probably due to me using npm 7+. Thanks for fixing! I keep meaning to switch back to v6, but version 7 is so much faster :p