search

tomaswolf / gerrit-gitblit-plugin

Integrates standard GitBlit (currently 1.7.1) as a repository viewer in Gerrit
Apache License 2.0
22 stars 5 forks source link

Update this plugin to use the gitblit 1.7.1 update #12

Closed paladox closed 8 years ago

paladox commented 8 years ago

Please update this plugin to use the new 1.7.1 update. Or use the version straight of master branch since there were some changes that were reverted but were re uploaded again after the update. Things such as raw was fixed.

Also make it compatible with gerrit 2.12 please.

paladox commented 8 years ago

https://github.com/gitblit/gitblit

paladox commented 8 years ago

Also the develop branch was removed in favour of using the master branch.

tomaswolf commented 8 years ago
  1. Current released version of Gerrit is 2.11.5. Once Gerrit 2.12 is officially released, I'll make sure that the plugin here works with it. I'm not building against unreleased versions or -rc versions.
  2. Now that James finally has officially released a 1.7 version of Gitblit, I will in time move to that. I will not build against his master branch; only against what's in his maven repository. If that is buggy (and I do see a few fixes since 1.7.1), I'll decide on a case-by-case basis.
tomaswolf commented 8 years ago

Update to Gerrit 2.12 done; see release 2.12.162.1.

Update to Gitblit 1.7.1 plus maybe some post-release fixes will take some more time.

paladox commented 8 years ago

Ok thanks. Maybe we would want to wait for 1.7.2 to be released since some fixes the were meant for 1.7.1 got reverted because a merge of branch reverted some changes by mistake which were re added. Or maybe you would incorporate those fixes when you update gitblit. The fix is viewing raw files which is currently broken if you view in such as repo such as example/example/example.

sschuberth commented 8 years ago

FYI, I recently did upgrade Luca's original plugin to GitBlit 1.7.1 before I got aware of this fork. You can probably take a look at my change to copy over the necessary API changes.

paladox commented 8 years ago

Thanks. Is it possible to use the latest change of master branch since viewing raw files is fixed in the latest change of master branch. It was meant to be released in the 1.7.x release but was reverted by mistake when the develop branch was merged.

sschuberth commented 8 years ago

It's not possible unless there are some pre-built (snapshot) artifacts available that contain this change. I guess it really would make sense to just wait for 1.7.2 in this case.

paladox commented 8 years ago

raw was broken in 1.6 and 1.5 I think.

tomaswolf commented 8 years ago

I've published a pre-release version for Gerrit 2.12 based on Gitblit 1.7.1 (with two post-1.7.1 PRs gitblit/gitblit#957 and gitblit/gitblit#983). See release v2.12.171.0.

Give it a try, and please report back whether it works or has problems. I didn't spot any.

tomaswolf commented 8 years ago

It's been more than two weeks, 9 downloads, and no bug reports. So I'll just assume that no news is good news and promote that release from pre-release to regular release.