search

tomaswolf / gerrit-gitblit-plugin

Integrates standard GitBlit (currently 1.7.1) as a repository viewer in Gerrit
Apache License 2.0
22 stars 5 forks source link

Clone URLs use sshd.listenAddress instead of sshd.advertisedAddress #19

Closed vipuldelwadia closed 8 years ago

vipuldelwadia commented 8 years ago

In my gerrit.confg, I have the following:

[sshd]
    listenAddress = 10.X.X.X:29418
    advertisedAddress = gerrit.X.com

When I view the clone URLs in GitBlit, I see the following:

gitblit-clone-url

i.e. the ssh://url is using the listenAddress but the http://url is using the advertisedAddress. The gerrit.X.com address is the right one and the ssh clone url is using the wrong one.

Is there a config I can set which fixes this discrepancy?

tomaswolf commented 8 years ago

Is there a config I can set which fixes this discrepancy?

No, there isn't one. I just looked at this code, which was taken over from the "official" plug-in: it's all hard-coded. I'll improve this and provide an updated release.

tomaswolf commented 8 years ago

Done in release 2.12.171.1. Please give it a try and report back whether this solves your issue. If so, I'll promote it from "pre-release" to a regular release.

vipuldelwadia commented 8 years ago

This works perfectly, thanks for fixing it so quickly!

tomaswolf commented 8 years ago

Thanks for reporting back. Release promoted.