Gitblit takes too long to initialize

tomaswolf / gerrit-gitblit-plugin

Integrates standard GitBlit (currently 1.7.1) as a repository viewer in Gerrit

Apache License 2.0

22 stars 5 forks source link

Gitblit takes too long to initialize #23

Closed tsuna closed 8 years ago

tsuna commented 8 years ago

When Gerrit starts, part of GitBlit's initialization includes preparing a 14 day commit cache. We repack our repos regularly, and don't even have that many (~70 repos totaling ~7GB of data) and yet it takes 5-10 minutes for GitBlit to build its commit cache, which significantly delays how quickly Gerrit can come back up after being restarted.

I don't know what the commit cache is used for, and I imagine the window (14 days) could be reduced via configuration (although I don't know what the consequences would be), but would it be possible to build this cache asynchronously in a background thread to not delay the startup sequence?

tomaswolf commented 8 years ago

5 to 10 minutes for 70 repos just doesn't sound right. Something must be severely amiss in Gitblit. I wonder what it caches -- all commits?

I'll take a look and see what I can do, but it's an area of Gitblit that I haven't ever dealt with. Depending on what I find I may or may not be able to do something about it.

In any case: I have taken a (bad) habit of doing little fixes in Gitblit directly here in this plugin instead of upstream in Gitblit itself because Gibtblit for a long time was stuck at 1.6.2. It looks as if James now again releases more frequently. Gitblit 1.8.0 is out, and I'll soon switch to that. So I think you should report this bug against Gitblit itself.

tomaswolf commented 8 years ago

Now that I've looked at that code, a couple of comments:

it appears this cache is used for the "activity" page, and for the activity graph top right of project pages.
it also appears that it isn't really needed.
it can be disabled by setting web.activityCacheDays in gitblit.properties to zero.
yes, it could be loaded in the background. It is a little bit of work since the cache itself it not fully thread safe, but that can be fixed easily enough.

tomaswolf commented 8 years ago

See also gitblit/gitblit#1076 and gitblit/gitblit#1091. I'll put together a fix for the plug-in, and then see if I can push that upstream.

tomaswolf commented 8 years ago

Fixed in the plugin in release v2.12.171.3.

If you could test, that'd be great.