search

tomaswolf / gerrit-gitblit-plugin

Integrates standard GitBlit (currently 1.7.1) as a repository viewer in Gerrit
Apache License 2.0
22 stars 5 forks source link

support for gerrit 2.14 #29

Closed stleusc closed 7 years ago

stleusc commented 7 years ago

Any plan to update the plugin for 2.14? The official plugin seems to have issues with raw links which always worked on older gerrit with your plugin.

tomaswolf commented 7 years ago

I've published release 2.14.171.0. Needed adaptations were really minor; quick tests showed no problems.

Give it a try, and please report back whether it's OK. I'll then promote it from pre-release to regular release.

Note that Gerrit 2.14 requires a Java 8 JRE, and so does this plugin now.

stleusc commented 7 years ago

Perfect, quick test here shows that it works nicely! One thing I noticed is that I can access files via RAW mode even when the user is not logged in.

In other words, a shared/leaked URL to a raw file will return the content, regardless of user authentication.

This is not new and has been like that in all previous version as far as I know.

I actually make use of this 'feature' right now so I'm not even sure I want it fixed ;-).

But then again, access to files in raw mode with mandatory authentication header would be better I guess.

Do you want me to create a separate issue for that? What are your thoughts?

tomaswolf commented 7 years ago

Yes, let's deal with that RAW authentication issue separately. But see issue #20 first, and please include the Gerrit config regarding access controls to the project where you experience this if you open an issue for that.