search

tomaswolf / gerrit-gitblit-plugin

Integrates standard GitBlit (currently 1.7.1) as a repository viewer in Gerrit
Apache License 2.0
22 stars 5 forks source link

Fix invalid escaped $ #9

Closed orgads closed 8 years ago

orgads commented 8 years ago

When using these escapes in gerrit.config, gerrit fails to start.

tomaswolf commented 8 years ago

We'll have to find a better way. These escapes are necessary for the maven resources plugin, which runs over the *.md files to insert the Gitblit and the plugin version. Without the escape, the documentation page will be wrong.

It never occurred to me that somebody would copy from the source file. And I forgot that it's also linked to here on Github.

Have you an idea how I could have the maven build insert the versions, but leave the ${file} unchanged?

And why does this backslash make Gerrit fail to start? Sounds rather fragile.

tomaswolf commented 8 years ago

Figured it out. Should be fixed by commit 6844763 and commit 8001c75. (Combined diff.)

Since this affected only the online docu here at GitHub, no new release is necessary for this.

orgads commented 8 years ago

Great, thanks!