search

tomaszaba / ipccheckr

Toolkit for Performing IPC Acute Malnutrition-related Data Checks
GNU General Public License v3.0
2 stars 0 forks source link

TESTING: Address issue of partial argument match of `code` to `codes` #61

Open ernestguevarra opened 22 hours ago

tomaszaba commented 6 hours ago

Hi Ernest,

I appreciate your review on this particular issue and for sharing that additional resource to read. During the development process, I strove to fix it but I could not. Now I understand why.

I was reflecting on the suggestion you put forward - to change code to .code. I remembered that the argument code comes from the {nipnTK}. So, I guess this suggestion wouldn't work, unless changed in the dependent package. Is my assumption correct?

ernestguevarra commented 4 hours ago

Hi Ernest,

I appreciate your review on this particular issue and for sharing that additional resource to read. During the development process, I strove to fix it but I could not. Now I understand why.

I was reflecting on the suggestion you put forward - to change code to .code. I remembered that the argument code comes from the {nipnTK}. So, I guess this suggestion wouldn't work, unless changed in the dependent package. Is my assumption correct?

@tomaszaba, it's good you reminded me of that as that pointed to me what the problem is. The issue is not with {nipnTK}. I ran devtools::check and I don't get partial matching issue. Which made me investigate further. When I looked at the documentation for sexRatioTest() which is the function that gives rise to this issue, I saw this:

?sexRatioTest

Usage
sexRatioTest(sex, codes = c(1, 2), pop = c(1, 1))

The name of the argument in {nipnTK} is codes and not code. But in your usage of the function in {ipccheckr}, you use code. This is what is meant by partial matching. The function still works because it matches partially with codes.

Please fix this accordingly.