search

tomaszpoliszuk / DarkMode-Flipswitch

Flipswitch toggle for Dark Mode feature.
http://cydia.saurik.com/package/com.tomaszpoliszuk.darkmodeflipswitch/
4 stars 2 forks source link

disbale dark mode doesn't work #1

Open orenmm opened 4 years ago

orenmm commented 4 years ago

Switch only enables the dark mode, when pressing the toggle again, light mode doesn't work.

tomaszpoliszuk commented 4 years ago

Try to remove (not reinstall) this flipswitch and then install it again. Let me know if it helped.

orenmm commented 4 years ago

The thing is it's now part of the Flipswitch package, I can remove it, but when I install it it says there is a conflict in the package and I have to remove both this and activator just to test it.

On Sun, Jun 7, 2020 at 5:36 PM Tomasz Poliszuk notifications@github.com wrote:

Try to remove (not reinstall) this flipswitch and then install it again. Let me know if it helped.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomaszpoliszuk/DarkMode-Flipswitch/issues/1#issuecomment-640228415, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUNO5TWT4BIMIATK6GBJOTRVOQWHANCNFSM4NXIFPGA .

tomaszpoliszuk commented 4 years ago

Yes - if you have flipswitch equal or higher than 1.0.16-beta6 then you shouldn't have this one installed since it's already build in into 1.0.16-beta6. Please remove this one and proceed into installing flipswitch 1.0.16~rc1.

orenmm commented 4 years ago

Removed the tweaks, installed flipswitch 1.0.16~rc1, latest DarkMode-Flipswitch, flipconvert. still acts in the same way, can only enable dark mode, not disabling it.

On Sun, Jun 7, 2020 at 5:43 PM Tomasz Poliszuk notifications@github.com wrote:

Yes - if you have flipswitch equal or higher than 1.0.16beta6 then you shouldn't have this one installed since it's already build in into 1.0.16 beta6. Please remove this one and proceed into installing flipswitch 1.0.16~rc1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomaszpoliszuk/DarkMode-Flipswitch/issues/1#issuecomment-640229463, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUNO5TFPLKE5Q3YZB2NFSLRVORSJANCNFSM4NXIFPGA .

tomaszpoliszuk commented 4 years ago

If you have flipswitch 1.0.16~rc1 then uninstall DarkMode-Flipswitch.

orenmm commented 4 years ago

sorry! i wrote the wrong version, meant to say: flipswitch 1.0.16 beta 5, that does not include DarkMode-Flipswitch. I get the same result with this option and with flipswitch 1.0.16~rc1 installed (automatically removes DarkMode-Flipswitch).

On Sun, Jun 7, 2020 at 6:28 PM Tomasz Poliszuk notifications@github.com wrote:

If you have flipswitch 1.0.16~rc1 then uninstall DarkMode-Flipswitch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomaszpoliszuk/DarkMode-Flipswitch/issues/1#issuecomment-640235757, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUNO5SHS5XMFBC4BSDWPPDRVOWY5ANCNFSM4NXIFPGA .

tomaszpoliszuk commented 4 years ago

Ok, labeled this as bug. I'll soon try to replicate it on my device and ask more questions if necessary.

shtuseriff commented 4 years ago

Just wanted to report that I have the same issue. I can’t disable dark mode from the switch; only enable it. Flipswitch v1.0.16~rc1.

PS, thanks for making this. I will FINALLY be able to use Flipconvert and theme my damn cc toggles. Held off because there was no DarkMode FS, and therefore it couldn’t be themed. Thank u ❤️

tomaszpoliszuk commented 4 years ago

@orenmm sorry - I wrote incorrectly - it's build in since beta7 not beta6.

orenmm commented 4 years ago

Yeah I checked the "change history" of Flipswitch to know which version to download. But both, your standalone version, and the one with it built, are not able to disable dark mode and return to light mode.

On Mon, Jun 8, 2020 at 6:46 PM Tomasz Poliszuk notifications@github.com wrote:

@orenmm https://github.com/orenmm sorry - I wrote incorrectly - it's build in since beta7 not beta6.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tomaszpoliszuk/DarkMode-Flipswitch/issues/1#issuecomment-640712041, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUNO5USYLCUC7ZRQE2AOH3RVUBWRANCNFSM4NXIFPGA .

tomaszpoliszuk commented 4 years ago

@orenmm @shtuseriff I've tested both options:

but I recommend to use first one since it have implemented bug fixes and some cool updates.

Assigned "Dark Mode" from "Switches" [not from "Switches (Activate)" - pointing this out "just in case" since Ii have only parts of informations I need] group and i've triggered it from few different events (like touching Touch ID or toggling from custom menu).

In both cases I could turn on and of Dark Mode.

I need you to do this steps:

Let me know how it works when you do this.

orenmm commented 4 years ago

I followed the steps you mentioned. it does work when assign a toggle gesture in Activator, but not as Flipswitch in the ControlCenter. Thats what me and @shtuseriff were having difficulty to achieve. There is the native iOS toggle, but you can't theme that icon because its animated. it can be themable with your toggle, but we can't disable the dark mode as I stated before. I hope its more clear now

tomaszpoliszuk commented 4 years ago

Oh - i didn't know that.

Could you provide me with name of tweak you use to enable usage of flipswitches in Control Center?

orenmm commented 4 years ago

CCModules + FlipConvert FlipConvert simply Convert Flipswitch Toggles for CCSupport

tomaszpoliszuk commented 4 years ago

Ok, now i get it.

After test I can confirm - this flipswitch after converting by FlipConvert doesn't work correctly.

However i'm not yet sure if this is something that can/should be corrected on my end or by julioverne.

I'll look more into it in near future 🙂

orenmm commented 4 years ago

I remember having an issue with caller ID toggle. The person who was behind that toggle had to fix it on his end. Cheers :)

Sent from my iPhone

On 8 Jun 2020, at 20:23, Tomasz Poliszuk notifications@github.com wrote:

 Ok, now i get it.

After test I can confirm - this flipswitch after converting by FlipConvert doesn't work correctly.

However i'm not yet sure if this is something that can/should be corrected on my end or by julioverne.

I'll look more into it in near future 🙂

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

shtuseriff commented 4 years ago

yes, @orenmm described the issue perfectly. I have _a guess _that it’s not an issue with FlipConvert. I believe I’ve seen similar issues in the past with a different switch and it was the switch itself. If it helps at all, I should mention that I do not have CCModules installed; so its not that. But like Oren, I do have FlipConvert.

tomaszpoliszuk commented 4 years ago

Just to be sure - I'm not suggesting anything at that point but since i'm stuck (but I have few ideas how to change it) at making control center toggle (one of my private, still not finished projects) and have some problems with dark mode in another one (another one not yet finished) I'm suspecting that figuring it out should help also in this case.

I'll probably try to investigate it tomorrow a little bit.

I have now FlipConvert installed for tests 🙂

shtuseriff commented 4 years ago

Any progress on this? We're so close to a fully themed CC... just need that little Dark Mode switch to play nicely when using FlipConvert. #MakeMyCCGreatAgain <3 Thanks man!

tomaszpoliszuk commented 4 years ago

I've made some progress but we are not there yet.