search

tomaszsita / wp-manual-image-crop

Repository of WordPress image cropping plugin http://wordpress.org/plugins/manual-image-crop/
67 stars 40 forks source link

Updated backend UI. Added new option to show cropping popup on new uploads. #49

Open RadGH opened 8 years ago

RadGH commented 8 years ago

Hi, this is my first pull request and I haven't published anything on WordPress.org yet. So you may want to thoroughly review any changes here. Mostly cosmetic changes, and one new but rather simple feature.

Here is the new settings page, to match the WP 4.3.1 style a bit better:

image

Here is the new popup page. Tabs have changed to match the media uploader better:

image

Finally, the new feature offers a checkbox on the settings page. If enabled, we trigger the crop popup when you upload a new image through the media uploader. But it's off by default.

RadGH commented 8 years ago

Oh yeah, another change to the "Crop Image" link that is injected into the media uploader.

image

  1. The link no longer has an underline, so it is consistent with Edit/Delete links.
  2. Fixed a bug where "Crop image" would go to another line instead of staying inline with the other details, when the image was aligned to the left.
  3. Prevented the link from being added repeatedly every 500ms. This caused some flickering that was difficult to notice, but affected keyboard control.
tomaszsita commented 8 years ago

Hi Radley,

Thanks for this! I will review over the weekend.

Kind Regards Tomasz Sita

On 2 December 2015 at 23:56, Radley Sustaire notifications@github.com wrote:

Hi, this is my first pull request and I haven't published anything on WordPress.org yet. So you may want to thoroughly review any changes here. Mostly cosmetic changes, and one new but rather simple feature.

Here is the new settings page, to match the WP 4.3.1 style a bit better:

[image: image] https://cloud.githubusercontent.com/assets/2008464/11547945/c4ffab94-990c-11e5-9d4a-0d3590136329.png

Here is the new popup page. Tabs have changed to match the media uploader better:

[image: image] https://cloud.githubusercontent.com/assets/2008464/11547959/d7934f9a-990c-11e5-860e-7ebf4e36f5cb.png

Finally, the new feature offers a checkbox on the settings page. If enabled, we trigger the crop popup when you upload a new image through the

media uploader. But it's off by default.

You can view, comment on, or merge this pull request online at:

https://github.com/tomaszsita/wp-manual-image-crop/pull/49 Commit Summary

  • Eliminated flickering of "Crop Image" link in media popup, slight js optimization
  • Styled "Crop Image" link in media popup to match Edit Image link, and fix erraneous wrapping issue
  • Style updates for MIC crop lightbox, matching the media frame styles
  • Improved layout of table on settings page
  • Reduced spacing of table and added max width, particularly for large screen.
  • New classes to enable striped rows and identify columns
  • Made image sizes text bold
  • Added plugin version numbers to MIC css/js
  • Updated version number to unofficial 1.12r1. Note: r1 is not valid for wordpress.org, use 1.13 instead
  • Removed unused function from previous commit
  • Updated tested version of WordPress to 4.3.1
  • Removed spaces
  • New option to ask if we should crop featured images when after they are uploaded
  • Now works for any newly uploaded image, not just featured image
  • Updated version again. Intentionally not WordPress.org compliant.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/tomaszsita/wp-manual-image-crop/pull/49.

RadGH commented 8 years ago

I've added one more feature which is totally separate from the others. but it looks like it got added to this pull request. You can take one or the other if you don't want both updates. Let me know if I need to do something to help with that.

Anyway, description of the latest commit:

I had a few plugins which were causing problems and I thought the plugin had stopped working. But it was other plugins overwriting the changes of MIC.

The latest update will display an error to inform these other plugins conflict. Pretty straightforward. It only detects two plugins currently, but you can add more plugins to the list with four lines of code (see plugin-conflicts.php:27-30).

image

Should all be translateable. Plugin names use the text domain of the respective plugin.