search

tomaszzmuda / Xabe.FFmpeg

.NET Standard wrapper for FFmpeg. It allows to process media without know how FFmpeg works, and can be used to pass customized arguments to FFmpeg from dotnet core application.
https://xabe.net/product/xabe_ffmpeg/
Other
711 stars 126 forks source link

Fix Pre-Input placement #444

Open adanvdo opened 1 year ago

adanvdo commented 1 year ago

Fix for Issue #425

adanvdo commented 1 year ago

@djon2003 FYI, Visual Studio warns me that there are inconsistent Line Endings in this file. Those were the formatting changes in the previous PR. I have left the original Line Endings unchanged in this commit.

djon2003 commented 1 year ago

@adanvdo I am aware of this, but I never gave the word to the owner of this repository.

@tomaszzmuda Look at the previous message. Others could also make the same "mistake" and it could be fixed easily by you. Thank you!

tomaszzmuda commented 1 year ago

@adanvdo There is a problem with tests. Some of them are failing and they goes too long. I guess something is wrong with your Pull Request.

@djon2003 I'm going to do that after that merge :)

adanvdo commented 1 year ago

@tomaszzmuda I have looked into the tests problem and I do not believe it is related to my code. If you look, you can see it is a very minor change. I just pushed a commit that removed some whitespaces that prevented me from being able to build the tests projects, but it was .net tests that exceeded 60m and I do not have any control over that.

tomaszzmuda commented 1 year ago

Thats the test results on my machine with your changes. image

and thats are from master: image

(RTSP is taking too long and audio and watermark test is failing - there is one test with hardware acceleration but it just doesn't work with my hardware)

adanvdo commented 1 year ago

(RTSP is taking too long and audio and watermark test is failing - there is one test with hardware acceleration but it just doesn't work with my hardware)

@tomaszzmuda are you able to give me the full exception and stack trace of the watermark exception? I can try to look into the rest.

tomaszzmuda commented 1 year ago

image It looks like problem is somewhere here: image