Closed Anthony-Gaudino closed 10 months ago
Handling all possible selection schemes would be a pain. It's up to the user to make the right selection. I emphasize that Curves WB is experimental. It is mainly my personal sandbox workbench, and should only be used at your own risks.
If a user selects two gordon surfaces and click on the create gordon surface tool an error will occur and it will appear as FreeCAD is running an infinite computation.
An error also appears if the user only selects a single gordon surface and tries to create a gordon surface. An invalid gordon surface will appear on tree view.
Example file: gordon_squares_2.FCStd.zip
I think Curves WB should disable the tool buttons if the selected geometry is incorrect or the number of items is not correct. For example, right now to create a gordon surface the user needs 4 edges / curves so the button should only be enabled if the user selects 4 edges / curves.
Also, since users can call the tool by Python script, it should handle the case the user tries to use it with incorrect inputs in code too.
Another option is to allow using gordon surfaces for creation of other gordon surfaces valid by implementing, for example, that if the user tries to create a gordon surface using other gordon surfaces a new valid surface is created using the other surfaces edges.