search

tomate44 / CurvesWB

Experiments for a FreeCAD Surface workbench
GNU Lesser General Public License v2.1
114 stars 24 forks source link

Join Curves fail but is fine on older versions #71

Closed mangojellysolutions closed 2 years ago

mangojellysolutions commented 2 years ago

Hi I have tried the following on both freeCAD 0.20 and 0.19 and I have tried this on a older version of the Curves workbench and it works fine. When I updated the workbench today and tried running a join curve between two lines (tried sketch edges, freehand curves, etc) I get the error message:

18:52:18 Traceback (most recent call last): File "/home/oranges/.local/share/FreeCAD/Mod/Curves/./freecad/Curves/JoinCurves.py", line 162, in execute obj.Shape = obj.ExtensionProxy.approximate(obj, outEdges) <class 'TypeError'>: type must be 'Shape', not list

This happens on both version of freeCAD. I am running on Ubuntu

Thanks

tomate44 commented 2 years ago

Hello, Indeed, I introduced a bug with my latest commit. It should be fixed now. BTW : Thanks a lot for all your great YT videos about the Curves Workbench.

mangojellysolutions commented 2 years ago

Ah great thank you for solving it so quickly. No problems regarding the videos, thank you for such a great workbench!! Being a Developer myself (in the Photography Industry) I know the last thing that I want to do is document the code I make, it just takes so much time, I am really happy to help. If you need anything documented in video form please let me know. I realise we have never really had any contact! I am Darren BTW :) I must start posting on the freeCAD forum at some point.

On Sun, 15 May 2022 at 08:18, Christophe Grellier @.***> wrote:

Hello, Indeed, I introduced a bug with my latest commit. It should be fixed now. BTW : Thanks a lot for all your great YT videos about the Curves Workbench.

— Reply to this email directly, view it on GitHub https://github.com/tomate44/CurvesWB/issues/71#issuecomment-1126876446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL24AC2PSSTK4HVS5E2CKA3VKCQNBANCNFSM5V54O5MA . You are receiving this because you authored the thread.Message ID: @.***>

tomate44 commented 2 years ago

Yes, that would be great if I could contact you on FreeCAD forum, because I have no Google account, for ethical reasons. BTW, I have a new surfacing tool that I hope to release soon.