search

tomatenquark / code

The code that powers Tomatenquark
https://tomatenquark.github.io/
Other
34 stars 5 forks source link

Git complains about "files that should have been pointers, but weren't" when cloning this repository #29

Closed Calinou closed 4 years ago

Calinou commented 4 years ago

Describe the bug

Git will print errors about files that should have been pointers, but weren't. This is only about compiled Windows libraries, so it's harmless on Linux. Still, I thought I'd report it.

For the record, I'm using Git 2.25.4 on Fedora 31.

To Reproduce

Run the following command:

git clone https://github.com/tomatenquark/code.git

You should see this warning message appear when Git is done cloning:

Encountered 53 file(s) that should have been pointers, but weren't:
    bin/SDL2.dll
    bin/SDL2_image.dll
    bin/SDL2_mixer.dll
    bin/libFLAC-8.dll
    bin/libjpeg-9.dll
    bin/libmikmod-2.dll
    bin/libmodplug-1.dll
    bin/libmpg123-0.dll
    bin/libogg-0.dll
    bin/libopus-0.dll
    bin/libopusfile-0.dll
    bin/libpng16-16.dll
    bin/libtiff-5.dll
    bin/libvorbis-0.dll
    bin/libvorbisfile-3.dll
    bin/libwebp-4.dll
    bin/libwebp-7.dll
    bin/libwinpthread-1.dll
    bin/smpeg2.dll
    bin/zlib1.dll
    bin64/SDL2.dll
    bin64/SDL2_image.dll
    bin64/SDL2_mixer.dll
    bin64/libFLAC-8.dll
    bin64/libjpeg-9.dll
    bin64/libmikmod-2.dll
    bin64/libmodplug-1.dll
    bin64/libmpg123-0.dll
    bin64/libogg-0.dll
    bin64/libopus-0.dll
    bin64/libopusfile-0.dll
    bin64/libpng16-16.dll
    bin64/libtiff-5.dll
    bin64/libvorbis-0.dll
    bin64/libvorbisfile-3.dll
    bin64/libwebp-4.dll
    bin64/libwebp-7.dll
    bin64/libwinpthread-1.dll
    bin64/smpeg2.dll
    bin64/zlib1.dll
    src/lib/SDL2.lib
    src/lib/SDL2_image.lib
    src/lib/SDL2_mixer.lib
    src/lib/enet.lib
    src/lib/zdll.lib
    src/lib64/SDL2.lib
    src/lib64/SDL2_image.lib
    src/lib64/SDL2_mixer.lib
    src/lib64/enet.lib
    src/lib64/zdll.lib
    src/vcpp/cube2.ico
    src/xcode/help/sauer16.png
    src/xcode/help/sauer32.png

Note that the files present on the local filesystem seem to be correct (they're present and not empty or tiny):

❯ ll bin64
Permissions Size User Date Modified Name
.rw-rw-r--  431k hugo 16 May 17:15  libcurl.dll
.rw-rw-r--  441k hugo 16 May 17:15  libFLAC-8.dll
.rw-rw-r--  244k hugo 16 May 17:15  libjpeg-9.dll
.rw-rw-r--  287k hugo 16 May 17:15  libmikmod-2.dll
.rw-rw-r--  252k hugo 16 May 17:15  libmodplug-1.dll
.rw-rw-r--  337k hugo 16 May 17:15  libmpg123-0.dll
.rw-rw-r--   52k hugo 16 May 17:15  libogg-0.dll
.rw-rw-r--  124k hugo 16 May 17:15  libopus-0.dll
.rw-rw-r--   46k hugo 16 May 17:15  libopusfile-0.dll
.rw-rw-r--  210k hugo 16 May 17:15  libpng16-16.dll
.rw-rw-r--  432k hugo 16 May 17:15  libtiff-5.dll
.rw-rw-r--  251k hugo 16 May 17:15  libvorbis-0.dll
.rw-rw-r--   69k hugo 16 May 17:15  libvorbisfile-3.dll
.rw-rw-r--  326k hugo 16 May 17:15  libwebp-4.dll
.rw-rw-r--  447k hugo 16 May 17:15  libwebp-7.dll
.rw-rw-r--  301k hugo 16 May 17:15  libwinpthread-1.dll
.rw-rw-r--  1.7k hugo 16 May 17:15  LICENSE.FLAC.txt
.rw-rw-r--  3.2k hugo 16 May 17:15  LICENSE.jpeg.txt
.rw-rw-r--   25k hugo 16 May 17:15  LICENSE.mikmod.txt
.rw-rw-r--   193 hugo 16 May 17:15  LICENSE.modplug.txt
.rw-rw-r--   41k hugo 16 May 17:15  LICENSE.mpg123.txt
.rw-rw-r--  1.6k hugo 16 May 17:15  LICENSE.ogg-vorbis.txt
.rw-rw-r--  2.1k hugo 16 May 17:15  LICENSE.opus.txt
.rw-rw-r--  1.6k hugo 16 May 17:15  LICENSE.opusfile.txt
.rw-rw-r--  5.6k hugo 16 May 17:15  LICENSE.png.txt
.rw-rw-r--   25k hugo 16 May 17:15  LICENSE.smpeg.txt
.rw-rw-r--  1.3k hugo 16 May 17:15  LICENSE.tiff.txt
.rw-rw-r--  1.7k hugo 16 May 17:15  LICENSE.webp.txt
.rw-rw-r--  1.7k hugo 16 May 17:15  LICENSE.zlib.txt
.rw-rw-r--   433 hugo 16 May 17:15  README-SDL.txt
.rw-rw-r--  1.5M hugo 16 May 17:15  SDL2.dll
.rw-rw-r--  125k hugo 16 May 17:15  SDL2_image.dll
.rw-rw-r--  123k hugo 16 May 17:15  SDL2_mixer.dll
.rw-rw-r--  388k hugo 16 May 17:15  smpeg2.dll
.rw-rw-r--  108k hugo 16 May 17:15  zlib1.dll

Expected behavior

Those warnings should not appear. We could find a way to solve this (not sure how), or remove compiled libraries from the repository.

Fohlen commented 4 years ago

Hey, you need to install git lfs in order to clone this repository because we don't push binary files directly, hope that helps!

Fohlen commented 4 years ago

Can this be closed @Calinou ?

Calinou commented 4 years ago

@Fohlen Sure :slightly_smiling_face:

Still, we might want to add a note about Git LFS to the README in the future.

Fohlen commented 4 years ago

f8f200898346235f9cb516416fc037639bb841c4