search

tomatoers / tomato

A simple, usable, and efficient pomodoro app designed for elementary OS
GNU General Public License v2.0
67 stars 15 forks source link

Show the window in the multi-task view #46

Open megatux opened 6 years ago

megatux commented 6 years ago

Probably the main window is hidden on purpose, but I find it annoying that I can not drag the app window between workspaces and that it is invisible when using multi-task view.

cassidyjames commented 5 years ago

This looks like it's because the main window is a dialog, which is discouraged by GTK. elementary OS does not show dialogs in the Multitasking View.

megatux commented 5 years ago

Interesting. Maybe related to the merged branch called tomato-as-dialog.

cassidyjames commented 5 years ago

Correct. Instead of a dialog, Tomato should use the .flat style class on the decoration to style it similarly to a dialog. This is what several small apps, including Dippi and Palette do.

marcelobalexandre commented 5 years ago

I created a draft PR (https://github.com/tomatoers/tomato/pull/64) to change the MainWindow to be a Gtk.Window instead of a Gtk.Dialog.

I'm not fluent on Vala so I'm not sure about which is the best approach to do this, please feel free to comment in my draft PR.

marcelobalexandre commented 5 years ago

The PR (https://github.com/tomatoers/tomato/pull/64) is ready for a review. ;)