tomatophp / filament-notes

Add Sticky Notes to your FilamentPHP dashboard with tons of options and style
https://tomatophp.com
MIT License
22 stars 3 forks source link

Icon Issue #2

Open AhmedNabil1992 opened 1 month ago

AhmedNabil1992 commented 1 month ago

i face issue after i create note svg(): Argument #1 ($name) must be of type string, null given, \resources\views\vendor\filament\components\icon.blade.php :24

Widget list and also note list , i try to create note with and without icon and same error

3x1io commented 1 month ago

okay, it was an update on filament-icons, filament-type and now it's fine just use composer update. and let me know if it's still exists.

AhmedNabil1992 commented 1 month ago

thanks for respond , i try composer update and issue still exist ,

image

3x1io commented 1 month ago

fixed in v1.0.7

paulmercs commented 1 month ago

why i have this error? SQLSTATE[HY000]: General error: 1 no such table: icons

when i am going to create new note? Screenshot 2024-07-24 202424

3x1io commented 1 month ago

you need sqlite3 ext on your php

paulmercs commented 1 month ago

image

already enabled but still not working. i am using laravel herd. Thank you

3x1io commented 1 month ago

can you try

php artisan filament-icons:install
AhmedNabil1992 commented 1 month ago

i make update , and try this php artisan filament-icons:install also same issue

3x1io commented 1 month ago

@AhmedNabil1992 @paulmercs what is your database driver?

paulmercs commented 1 month ago

image

i am using mysql

AhmedNabil1992 commented 1 month ago

sql server

3x1io commented 1 month ago

please provide the FilamentPHP version and PHP version because I tried it and I don't get the same error!

AhmedNabil1992 commented 1 month ago

FYI i`m not facing any issue when i execute command php artisan filament-icons:install Loading Icons... Icons Has Been Installed And Cached!

but there is no table call icons in my database

paulmercs commented 1 month ago

please provide the FilamentPHP version and PHP version because I tried it and I don't get the same error!

FilamentPHP v3.2.95 PHP v8.3.8

3x1io commented 1 month ago

@AhmedNabil1992 It's okay because it's just a SQLite caching file so you don't get any tables on your database.

AhmedNabil1992 commented 1 month ago

php -v PHP 8.2.20 Filament v 3.2.96

3x1io commented 1 month ago

@AhmedNabil1992 @paulmercs do you try composer update?

AhmedNabil1992 commented 1 month ago

yes

paulmercs commented 1 month ago

@AhmedNabil1992 @paulmercs do you try composer update?

done that already.

3x1io commented 1 month ago

okay i will check it again on a fresh install

paulmercs commented 1 month ago

okay i will check it again on a fresh install

Thank you.

3x1io commented 1 month ago

Screenshot 2024-07-24 at 3 54 50 PM

@AhmedNabil1992 @paulmercs you get this problem when create a new note with icon?

AhmedNabil1992 commented 1 month ago

with and without

AhmedNabil1992 commented 1 month ago

i try now fresh install , but there is error image

3x1io commented 1 month ago

fixed in v1.0.9 try it now with composer update

paulmercs commented 1 month ago

image

i cannot create a note because of this error. i installed the plugin in my existing project.

also i update the plugin to 1.0.9 same issue

3x1io commented 1 month ago

@AhmedNabil1992 do you have the same?

3x1io commented 1 month ago

@paulmercs i think your problem still with SQLite3 so if you can try to use SQLite3 as a database and check it works or not.

paulmercs commented 1 month ago

@paulmercs i think your problem still with SQLite3 so if you can try to use SQLite3 as a database and check it works or not.

will try it fresh install

AhmedNabil1992 commented 1 month ago

after update on fresh install , using sqllite as db it`s worked fine but on sqlsrvr not working with me same error

AhmedNabil1992 commented 1 month ago

when i change database connection on fresh install to sql server it`s worked , but on another project same error , try remove and install again ?

paulmercs commented 1 month ago

same as mine

3x1io commented 1 month ago

I think it's maybe a version problem, but for now, @AhmedNabil1992 @paulmercs it's working on a freshly installed project?

AhmedNabil1992 commented 1 month ago

I think it's maybe a version problem, but for now, @AhmedNabil1992 @paulmercs it's working on a freshly installed project?

Yes , on both db connection

OccTherapist commented 1 month ago

image

i cannot create a note because of this error. i installed the plugin in my existing project.

also i update the plugin to 1.0.9 same issue

I have the same issue on the production environment. On local it works fine. sqlite3 extension is installed on both systems, also tested with php 8.2 and 8.3

OccTherapist commented 1 month ago

I managed to make it work.

I run following commands:

php artisan filament-icons:clear

and then

php artisan filament-icons:install

There might be an issue on environments with already cached icons?

3x1io commented 1 month ago

@OccTherapist thanks for your help and support I think that's it, a cache of filament-icons I will run this commands on an install command for Filament Notes to make sure that the icons is working fine