Android support - Githubissues

samhunta commented 8 years ago

Does this work for Android?

tomauty commented 8 years ago

I'll leave this one open. I'm starting work on it next week. It will be under the 2.0 branch, since this will be a massive overhaul.

pinhopro commented 8 years ago

@tomauty Please, post your bitcoin wallet. I will send you a donation to help you with the android port :)

tomauty commented 8 years ago

hah don't worry about that, I'll be trying to figure it out soon :)

cablegunmaster commented 8 years ago

How is this coming along?

Plus 1 for the effort, its one of the best react-native graphs/charts thusfar! :+1:

tomauty commented 8 years ago

I'm working on a 2.0 branch that will be pure JS. Hope to make some progress this week.

holyxiaoxin commented 8 years ago

I will donate as well! <3

Rpaixao commented 8 years ago

I really need this component! Go ahead! I am able to donate too ;)

tomauty commented 8 years ago

In lieu of donations, I'd appreciate links to other react charting libraries with a similar feature set. Looking for some guidance on architecture. I'm hoping to have a useable bar chart on 2.0 next week, then line, then feature parity.

cablegunmaster commented 8 years ago

Keep up the goodwork Tomauty, tried to test it today but guess the 2.0 version is not ready yet ;).

tomauty commented 8 years ago

Hey y'all. Some exciting news on this front. I've had the go-ahead at work to go full-force with this for part of the week. Here are some screenshots of 2.0 so far.

simulator screen shot apr 26 2016 10 12 33 am

Unfortunately there are some difficulties with animations which might make 2.0 an alpha/beta for a while, but it should be usable in its alpha stage on both platforms sometime next week for testing.

tomauty commented 8 years ago

Note that 2.0 has no objective-C code, or dependencies :)

tofrookie commented 8 years ago

i can't wait :)

pinhopro commented 8 years ago

Awesome .... 👍 post a bitcoin address so I can give you a tip :)

cablegunmaster commented 8 years ago

Keep up the good work Tomauty! :+1:

tomauty commented 8 years ago

Update – haven't had much time to work on this the past week or two, but I will have lots of time this weekend. I will update this thread when 2.0 is stable enough so you guys can test. Tentative plan is to merge 2.0 into master branch on Sunday, with approximate feature parity.

rgoldiez commented 8 years ago

Any update?

tomauty commented 8 years ago

Sorry, got caught up a bit. Almost done, just fixing some pie chart bugs and standardizing the API :)

rupeshdeotale97 commented 8 years ago

@tomauty Any update for android RN 0.24 .

rgoldiez commented 8 years ago

Any update on 2.0?

tomauty commented 8 years ago

Sorry I'm way behind schedule here. Things have slowed down a bit at work, so I'll try my best to get something out the door this week. Please bug me about it :)

cablegunmaster commented 8 years ago

Ah, easy is it working?? bugs you about it ;) & just because you asked.

Mindaugas-Jacionis commented 8 years ago

Any news? :)

tomauty commented 8 years ago

Sorry I'm posting in a bunch of issues. I'm standardizing the API and documentation today, then it should be ready for use.

cablegunmaster commented 8 years ago

I am awaiting eagerly hopefully to put this in production after release.

cablegunmaster commented 8 years ago

@tomauty

Feedback on current stage of production:

what I did to make it run changed the dependency's on the react and react-native because of some bug which didnt make it run. -> https://github.com/jhabdas/react-native-webpack-starter-kit/issues/101

Package.json: "dependencies": { "react": "^15.1.0", "react-native": "^0.27.2" },

Index.android.js: import Chart from './src/Chart'; ` <Chart
showAxis type='bar'

                    data={[[0, 1], [1, 3],[3, 7],[4, 9],[4, 200],[5, 20],[6, 60]]}
                    style={styles.chart}
                    axisColor={colors.grey}
                    gridColor={colors.grey}
                    chartData={this.state.barChart}
                    xAxisLabels={this.state.xLabels}
                    axisLabelColor={colors.grey}
                    showYAxisLabels
                    showXAxisLabels
                />

` Barchart seems stable so far, as far as the other 2 charts, the pie chart and the line chart, its a no show yet. No idea what pi chart is doing but it ain't doing as its supposed to.

In Short:

Updated dependancy react-js natve to show the chart. (couldnt understand the error)
Still a bug in receiving the props of the 'type' ( if you wanted to not include the 'type' in Chart itself. )
A bug in the piechart which overflows it with one color.
Linechart not showing (yet).

Hopefully this will help your development ;)! Trying to help you.

tomauty commented 8 years ago

Sorry guys, I am completely swamped by work this week :(

tomauty commented 8 years ago

This was on android, yes?

cablegunmaster commented 8 years ago

Correct this was on android

Mindaugas-Jacionis commented 8 years ago

Hi! How is it going with 2.0? :)

tomauty commented 8 years ago

This week. I promise! :)

esutton commented 8 years ago

Links to a cross-platform charting library that is reported to be releasing the react-native version this Friday, June 17.

Documentation looks good as well as the sample images.

No idea how stable or usable it will be from the start but they look like they have funding and full-time resources.

Many Examples:

tomauty commented 8 years ago

https://github.com/facebook/react-native/commit/13acd7ed7e641f80c8cfecf949a96c336300d403

This is causing the stagnant pie chart issue. Any workarounds or suggestions would be appreciated.

ggaabe commented 8 years ago

@esutton Where did you see that this library would be available by June 17th?

esutton commented 8 years ago

A Victory developer on Gitter told me so.

Sent from my iPhone

On Jun 17, 2016, at 12:44 PM, Gabriel Garrett notifications@github.com<mailto:notifications@github.com> wrote:

@esuttonhttps://github.com/esutton Where did you see that this library would be available by June 17th?

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/tomauty/react-native-chart/issues/59#issuecomment-226834849, or mute the threadhttps://github.com/notifications/unsubscribe/AF1O5_7LD0RhmdRvRoJ3kB1CiIyURbpWks5qMt0XgaJpZM4HzVDc.

rgoldiez commented 8 years ago

Almost, their devs responded to a github issue in their repo saying this week.

On Jun 17, 2016, at 1:23 PM, esutton notifications@github.com wrote:

A Victory developer on Gitter told me so.

Sent from my iPhone

On Jun 17, 2016, at 12:44 PM, Gabriel Garrett notifications@github.com<mailto:notifications@github.com> wrote:

@esuttonhttps://github.com/esutton Where did you see that this library would be available by June 17th?

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/tomauty/react-native-chart/issues/59#issuecomment-226834849, or mute the threadhttps://github.com/notifications/unsubscribe/AF1O5_7LD0RhmdRvRoJ3kB1CiIyURbpWks5qMt0XgaJpZM4HzVDc. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

tomauty commented 8 years ago

Hi guys. Fingers crossed here. I will appreciate lots of feedback and PRs in the coming weeks. I've published on npm as 1.0.0-beta.

tomauty commented 8 years ago

With that in mind, I will close this for now and accept more specific issues regarding Android support.

Dacello commented 8 years ago

@tomauty how do you go about linking libraries for android in 1.0.0-beta version?

tomauty commented 8 years ago

It should be linked automatically for Android. iOS requires ART linking.

Dacello commented 8 years ago

Ah ok. Thanks for the quick reply

tomauty / react-native-chart

Android support #59