Allow to download the GeoNames data at post-install

itaisatati commented 2 years ago

My second PR for this project :)

Addressing the suggestion at #53, this PR includes the following:

A post-install script which runs the initialization function. The parameters are passed via env-variables.
A short description & example in the documentation
All of the methods used here are supported from Node v6+, no breaking changes

Please let me know what you think:

The files are tagged with the current date so initializing at a different date will not gain anything from this effort Should there be an initialization option to save the files without a date tag?
Should the Dockerfile be modified to use this post-install script instead of curl? It will thereby get more usage and better feedback

itaisatati commented 1 year ago

Thanks for reviewing :) Let me know if there's something that's not in the issues tab and worth working on.

tomayac commented 1 year ago

Just published as v0.12.6.

ngoclong19 commented 1 year ago

npm install is failing with this error 'Error: Cannot find module '[...]\node_modules\local-reverse-geocoder\postinstall.js''.

I think postinstall.js is needed to included in array files of package.json.

itaisatati commented 1 year ago

@ngoclong19 Sorry about that. https://github.com/tomayac/local-reverse-geocoder/pull/61: I created a PR to fix the problem

tomayac / local-reverse-geocoder