tomayac / local-reverse-geocoder

Local reverse geocoder for Node.js based on GeoNames data
Apache License 2.0
190 stars 60 forks source link

build docker image and push to ghcr #74

Closed electriquo closed 1 year ago

electriquo commented 1 year ago

Fix #72

Test:

tomayac commented 1 year ago

Thanks for working on this. Looks like I would need to set up the access tokens and maybe register with Docker (since I don’t see it yet). Just let me know the required steps from my end. Thanks!

electriquo commented 1 year ago

Looks like I would need to set up the access tokens and maybe register with Docker (since I don’t see it yet)

From what I know, you don't need anything, refer to my testing and https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-github-packages. The workflow uses all GitHub builtin mechanism and the Docker image will be pushed to GitHub Container Registry using GitHub token.

All should just work once you merge and push a new tag.

tomayac commented 1 year ago

Amazing. I’ll take a proper look next week. Thanks again for working on this!

electriquo commented 1 year ago

I’ll take a proper look next week.

Can you share why next week and not now? :) Let the community enjoy this contribution rather than pulling from my fork.

tomayac commented 1 year ago

This seems to have worked.

electriquo commented 1 year ago

@tomayac Indeed https://github.com/tomayac/local-reverse-geocoder/pkgs/container/local-reverse-geocoder :)

electriquo commented 1 year ago

@tomayac Since you did not push a tag, the Docker image is tagged as main without any version. Will advise to push tag for the release.

tomayac commented 1 year ago

Done: https://github.com/tomayac/local-reverse-geocoder/tags.

electriquo commented 1 year ago

@tomayac Now it looks as it should and the image has been assigned with a version https://github.com/tomayac/local-reverse-geocoder/pkgs/container/local-reverse-geocoder/97505674?tag=v0.16.2

tomayac commented 1 year ago

Perfect, thanks again for contributing this!