tomayac / local-reverse-geocoder

Local reverse geocoder for Node.js based on GeoNames data
Apache License 2.0
190 stars 60 forks source link

Replace `request` with `node-fetch@2` #75

Closed yukha-dw closed 1 year ago

yukha-dw commented 1 year ago

Replace deprecated request with better maintained package, node-fetch. Latest node-fetch version is already implementing ES Modules, while this library uses CommonJS. Hence, I'm using node-fetch v2 for broader backward compatibility. But, if we want to use later version, we could use dynamic import (https://github.com/node-fetch/node-fetch#commonjs).

socket-security[bot] commented 1 year ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Network access node-fetch 2.6.11 package-lock.json, package.json

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore node-fetch@2.6.11
socket-security[bot] commented 1 year ago

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives^1 Size Publisher
node-fetch 🆕 2.6.11 network +3 492 kB node-fetch-bot

🚮 Removed packages: request@2.88.2