search

tomayac / wikipedia-tools-for-google-spreadsheets

Wikipedia Tools for Google Spreadsheets — Install:
https://gsuite.google.com/marketplace/app/wikipedia_and_wikidata_tools/595109124715?pann=cwsdp&hl=en
Apache License 2.0
145 stars 32 forks source link

Make error handling configurable: silent ignore (current) or loud fail #21

Open alexrollin opened 7 years ago

alexrollin commented 7 years ago

A little help with how to use the WIKIDATAQID would be very much appreciated:

This works:

=WIKIDATAQID("en:Banded_woodpecker")

However, if Cell C25 = "en:Banded_woodpecker"

Then this doesn't work :

=WIKIDATAQID(C25)

tomayac commented 7 years ago

If you don't see results at all, probably you have exceeded your daily allowance of API calls, the tool internally logs this as exception: Service invoked too many times for one day: urlfetch. Else, could you maybe share a test spreadsheet where this issue appears?

viswam commented 7 years ago

Hi,

I have tried the same. (Have not ran out of API count).

The function works if the cell with the string to which the function's parameter points does not contain quotes. With the quotes, it shows up a blank cell.

(Use just en:Banded_woodpecker instead of "en:Banded_woodpecker" in the parameter cell). This is quite in tune with the normal spreadsheet conventions.

-User:Viswaprabha

On 24 August 2017 at 17:01, Thomas Steiner notifications@github.com wrote:

If you don't see results at all, probably you have exceeded your daily allowance of API calls, the tool internally logs this as exception: Service invoked too many times for one day: urlfetch. Else, could you maybe share a test spreadsheet where this issue appears?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tomayac/wikipedia-tools-for-google-spreadsheets/issues/21#issuecomment-324609619, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuZ5XfnCp7A3qp_SVdJ0NUse7U16xo5ks5sbV8NgaJpZM4PBLQS .

alexrollin commented 7 years ago

Huh...i SWEAR it didn't work before, but it works now, so great!

Before I had just instealled the addon and it "felt" like the neighboring cell value was not being injected before the WIKIDATAQID function was being executed. I have since reopened the sheet and it appears to be in fine working order without the quotes. Viswan as you say it is in tune with convention.

Thank you for a fine and useful tool and for your support!

tomayac commented 7 years ago

Alright, so it’s definitely a quota issue, thanks for confirming.

Honestly, I don’t know what the best solution would be, return nothing (current behavior) or return some sort of error message.

The issue I see with error messages is chained functions that would horribly break.

Apparently according to this article custom functions can throw errors. Would the community prefer this over of failing silently?

viswam commented 7 years ago

An error output, preferably indicating specific cause will be better. Even better, if an optional parameter can be added to silence the error.

On 24 August 2017 at 21:05, Thomas Steiner notifications@github.com wrote:

Alright, so it’s definitely a quota issue, thanks for confirming.

Honestly, I don’t know what the best solution would be, return nothing (current behavior) or return some sort of error message.

The issue I see with error messages is chained functions that would horribly break.

Apparently according to this article https://support.google.com/docs/forum/AAAABuH1jm0GD0MWNwrpyY/?hl=en custom functions can throw errors. Would the community prefer this over of failing silently?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tomayac/wikipedia-tools-for-google-spreadsheets/issues/21#issuecomment-324672424, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuZ5VvFqtjFvMjd01fuoB-eqgf7t2tUks5sbZhQgaJpZM4PBLQS .