search

tomaz / zx-next-dev-guide

Guide for ZX Spectrum Next assembler developer. Available as free to download PDF from releases page, or printed coil bound book at https://bit.ly/zx-next-assembler-dev-guide
Other
141 stars 10 forks source link

LDDX is documented incorrectly #21

Closed taylorza closed 2 years ago

taylorza commented 2 years ago

Chapter 4.15 : LDDX documented as BC = BC + 1, this should be BC = BC - 1 Same on page 171 in Chapter 5

tomaz commented 2 years ago

Thanks, will fix! It's likely wrong in all places where LDDX is listed since all instruction "components" are implemented as reusable macros

tomaz commented 2 years ago

Finally fixed 😅

Thanks again for mentioning. Also again, big thanks for your PR too! Definitely let me know if you spot anything else - just open an issue, or if you feel for it, create PR, both will go big ways into making the book more accurate. Attaching updated PDF. I'll wait a bit in case other issues are reported then probably create another pre-release here.

zx-next-dev-guide.pdf

taylorza commented 2 years ago

Hi,

You are welcome and thank you for putting this together it is an awesome resource. It is much easier to get started with than anything else I have come across.

Best Regards, Chris

From: tomaz @.> Sent: Monday, February 7, 2022 2:59 AM To: tomaz/zx-next-dev-guide @.> Cc: Chris Taylor @.>; Author @.> Subject: Re: [tomaz/zx-next-dev-guide] LDDX is documented incorrectly (Issue #21)

Finally fixed 😅

Thanks again for mentioning. Also again, big thanks for your PR too! Definitely let me know if you spot anything else - just open an issue, or if you feel for it, create PR, both will go big ways into making the book more accurate. Attaching updated PDF. I'll wait a bit in case other issues are reported then probably create another pre-release here.

zx-next-dev-guide.pdfhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftomaz%2Fzx-next-dev-guide%2Ffiles%2F8013334%2Fzx-next-dev-guide.pdf&data=04%7C01%7C%7Caf1929cf79334b4e669308d9ea0fbc79%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798175576407649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KcERmlJjYZsj29K2yCXkkzGGQtjPCZst4k%2FFdpn0nEY%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftomaz%2Fzx-next-dev-guide%2Fissues%2F21%23issuecomment-1031171033&data=04%7C01%7C%7Caf1929cf79334b4e669308d9ea0fbc79%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798175576407649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MLRW08qR2WNqNMN9moOjbrm7mMr%2FI5v%2BygpKV%2FcK0Cg%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADETQ6FJDLNFIUAYZ7X3A73UZ53VFANCNFSM5MH6MC2Q&data=04%7C01%7C%7Caf1929cf79334b4e669308d9ea0fbc79%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798175576407649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xpJLgL0Gh43bTXPlV3KO6mDxhIqSXxUqL4b7XJzBfM8%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Caf1929cf79334b4e669308d9ea0fbc79%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798175576407649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YJiGBjmkXJYccCpI2f%2FJd1YHA1jyo9xVtuQoVsKq8Kk%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Caf1929cf79334b4e669308d9ea0fbc79%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798175576407649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=2vmUzszzX%2FgI%2BngrOehOsg3cyJwXiTavZDvwMGxHtTc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>