tombatossals / angular-leaflet-directive

AngularJS directive to embed an interact with maps managed by Leaflet library
http://tombatossals.github.io/angular-leaflet-directive
MIT License
1.5k stars 635 forks source link

Marker Events example is out-of-date #1009

Closed EricWVGG closed 9 years ago

EricWVGG commented 9 years ago

http://tombatossals.github.io/angular-leaflet-directive/examples/0000-viewer.html#/markers/events-example

It makes reference to a LeafletEvents module; that module is now called LeafletEventsHelper, and anyway doesn't appear to be necessary to initiate events.

nmccready commented 9 years ago

I think the github pages are out of date. The example in the src examples directory appears correct . https://github.com/tombatossals/angular-leaflet-directive/blob/master/examples/0115-basic-events-example.html

@tombatossals ls am not sure how the whole get pages are being handled. Are then generated from the src/examples here. Anyway someone needs to PR the work or update the site.

thulioph commented 9 years ago

I have the same problem here ;~

screen shot 2015-10-28 at 4 00 16 pm

tombatossals commented 9 years ago

Finally solved! Some of the latest added examples broke the examples generation page, nothing related with the example. The script generator needs that the controller name of each example was different.

Working again. Thanks for reporting guys.