search

tombatossals / angular-leaflet-directive

AngularJS directive to embed an interact with maps managed by Leaflet library
http://tombatossals.github.io/angular-leaflet-directive
MIT License
1.5k stars 635 forks source link

Give markers another option to update the popup layout after loading compiled content without ngInclude #793

Closed sibbl closed 9 years ago

sibbl commented 9 years ago

I do have the problem that after compiling the marker popup content, the size of the popup is not re-calculated. Afaik the popup size is only updated when the message includes the string "ngInclude".

In my eyes, that's not enough since I use a custom directive for the message (which of course does not have "ngInclude" in it), but loads a template anyway. Like:

  message: '<my-directive-that-includes-a-template param="' + param + '"></my-directive-that-includes-a-template>',

I'd love to be able to set "marker.watchForContentLoad = true" and have the angular leaflet directive also watch for the "$includeContentLoaded" event as well. Only looking for "ngInclude" in the message string looks promising, but is not enough.

j-r-t commented 9 years ago

800

sibbl commented 9 years ago

@jessertaylor thanks for fixing it that quick! Just a small question: how long does it take to bower recognize the new version 0.8.4? Bower install still has 0.8.3. Hope you can give me a small hint. Thx :)

sibbl commented 9 years ago

Seems like the 0.8.4 tag is missing at the release commit. Has nothing to do with this issue, so will open another one. Thanks again :+1:

j-r-t commented 9 years ago

you can specify master until a release is made.

nmccready commented 9 years ago

Its resolved.