Checking for undefined in $destroy handler

tombatossals / angular-openlayers-directive

AngularJS directive to embed an interact with maps managed by the OpenLayers library

http://tombatossals.github.io/angular-openlayers-directive/

MIT License

282 stars 183 forks source link

Checking for undefined in $destroy handler #314

Closed ekerkenaar closed 8 years ago

ekerkenaar commented 8 years ago

When using version 1.15.2, our unit tests report the follow error: undefined is not an object (evaluating scope.properties.handleInteraction)

This seems to be caused by an undefensive teardown when using a marker without any properties attached.

(Reporting this issue on behalf of @njirem who will send you a PR soon).

ekerkenaar commented 8 years ago

Cool @njirem That was quick ;)

njirem commented 8 years ago

You're welcome. :-) Build still fails because of issue #311 though.

juristr commented 8 years ago

@ekerkenaar @njirem Great stuff guys! I merged in everything. The build chain should pick up soon and publish everything out on npm and bower. Thx a lot! :+1: