tombatossals / angular-openlayers-directive

AngularJS directive to embed an interact with maps managed by the OpenLayers library
http://tombatossals.github.io/angular-openlayers-directive/
MIT License
283 stars 184 forks source link

<fix>: IE polyfill issue fix #358

Closed dulcedilip closed 7 years ago

dulcedilip commented 7 years ago

IE polyfill issue fix

startswith doesn't support in IE , so I have added polyfill support in olhelper.js.

2017-03-10 17_04_40-c__angular-openlayers-directive_examples_085-events-kml-example html - internet

juristr commented 7 years ago

@dulcedilip I just ran into this very same issue in my app :smile:

But that said, I'd rather simply use indexOf at this point, basically this line from the polyfill

this.indexOf(searchString, 0) === 0;

..instead of including the polyfill code directly in the helpers file here. Could you maybe fix this in your branch? Also, please make sure to exclude the dist folder from the commit. That folder gets generated automatically during our build process and is actually not included in the master branch.

thanks a lot

juristr commented 7 years ago

@dulcedilip Had to fix this quickly as it caused us issues in production. Thanks a lot for your PR :+1:

dulcedilip commented 7 years ago

@juristr super cool thanks for quick turn around. i thought to go with indexOf, i thought you have specific reason in doing so.

regards dilip

On 10 Mar 2017 11:12 p.m., "Juri Strumpflohner" notifications@github.com wrote:

[image: Boxbe] https://www.boxbe.com/overview This message is eligible for Automatic Cleanup! (notifications@github.com) Add cleanup rule https://www.boxbe.com/popup?url=https%3A%2F%2Fwww.boxbe.com%2Fcleanup%3Fkey%3DoD6oBLAayXYpLsBI8NsCTnGfcV5OlwMxjNxX6Z40GB0%253D%26token%3DrgGJpaQTKJAnWkauC%252BFYKeNNEwhIN%252BI3Jp7l4MwmqTZQE%252FAWcoHO0yZskIaYPVjkr%252B7tUSNbNMMuxR9tj7aluHeFxq5nImaS%252BZIdhu90OaMaBP3ygW3o6jI45bIntPaadT0aoHQVXVvpAnboVzdibg%253D%253D&tc_serial=29260808776&tc_rand=1559226344&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001 | More info http://blog.boxbe.com/general/boxbe-automatic-cleanup?tc_serial=29260808776&tc_rand=1559226344&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001

@dulcedilip https://github.com/dulcedilip Had to fix this quickly as it caused us issues in production. Thanks a lot for your PR 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tombatossals/angular-openlayers-directive/pull/358#issuecomment-285735220, or mute the thread https://github.com/notifications/unsubscribe-auth/AEtRcZ0H4R6MbhBWU4UCGmrsSxdj11Wdks5rkYuNgaJpZM4MZSY1 .