WP admin styles

[felipeelia]

Hi! First of all congratulations for this excellent plugin.

This PR intends to apply the WordPress style to forms in Dashboard. Changes are:

• The MvcFormHelper class received two new methods (open_admin_table() and close_admin_table()), one attribute ($is_in_admin_table), and create method now handles a is_admin option.
• Admin Template models (add.php and edit.php) are already created that way.

I've also removed the closing PHP tags from pure PHP files. Omitting them we help avoiding "headers already sent" issues.

[cyberscribe]

Thanks for this. May I ask why you define a custom is_admin class variable instead of using the is_admin() WP function? Just trying to understand the code...

[felipeelia]

Hi @cyberscribe! I've defined it to avoid breaking retrocompability. I thought that sites already using the plugin won't update to a version that adds tables automatically. Am I right?

Also, I've made another changes/improvements on my own fork. Let me know if you want a PR for those too (or if you note something that wasn't necessary). One of them makes a huge change in code presentation (but zero changes in funcionality): it's the PHPCBF run.

This is a very nice plugin, thanks for sharing it and congratulations! :)

[cyberscribe]

Great, thanks for being careful about backwards compatibility!

[cyberscribe]

It would be great to incorporate your other changes, but we'd need very thorough testing for backwards compatibility before we could release this... thoughts?

[felipeelia]

thoughts? Actually no :( I've been cautious, but can't guarantee it all works. I'm using the plugin in a project that killed all my spare time, but when it's over I think I can make a plan of minor PRs. What do you think?

[cyberscribe]

Hi Felipe--would be great to have your contributions. I too use it with many clients, so this is why I am cautious about backwards-compatibility.