Passed total_objects from collection to pagination, so one can show in a list (or table) how many items were found.
Modified admin_header_cell to append a class to "manage-column", in this case I chose " wpmvc-actions" (watch the leading whitespace so the append to manage-column works as 2 separate classes, basically I needed this to have this in a print.css, to hide the actions column in a table:
.wpmvc-actions { display: none; }
In the call to add_settings_field I added $setting['args'] in this case we can pass additional arguments to the settings, I use it to pass label_for so the display of settings is cleaner example:
Other changes are basically in translation and testing with isset before using.
$this->helper->plugin_name in pluggable/views/admin/index.php allows me to use my own plugin's name for translation purposes in admin views instead or using wpmvc.
For mvc_settings.php getting plugin_name from the registry I took similar code from core/helpers/mvc_helper.php
Ps. These changes are from 2017 but wanted to send a PR, I believe they won't break anything hopefully
Passed total_objects from collection to pagination, so one can show in a list (or table) how many items were found.
Modified admin_header_cell to append a class to "manage-column", in this case I chose " wpmvc-actions" (watch the leading whitespace so the append to manage-column works as 2 separate classes, basically I needed this to have this in a print.css, to hide the actions column in a table:
.wpmvc-actions { display: none; }
In the call to add_settings_field I added $setting['args'] in this case we can pass additional arguments to the settings, I use it to pass label_for so the display of settings is cleaner example:
Other changes are basically in translation and testing with isset before using.
$this->helper->plugin_name in pluggable/views/admin/index.php allows me to use my own plugin's name for translation purposes in admin views instead or using wpmvc.
For mvc_settings.php getting plugin_name from the registry I took similar code from core/helpers/mvc_helper.php
Ps. These changes are from 2017 but wanted to send a PR, I believe they won't break anything hopefully