search

tombenner / wp-mvc

An MVC framework for WordPress
http://wpmvc.org
MIT License
623 stars 172 forks source link

Add a real purpose of "title" property in settings #249

Closed celorodovalho closed 4 years ago

cyberscribe commented 4 years ago

str_replace(' Settings', '', $title); seems like a cosmetic choice and not something we necessarily want to enforce everywhere.

celorodovalho commented 4 years ago

What is the purpose of $title property? There is no use for that a some cases I don't my menu item called: SomeWeirdNameOfAClass as Some Weird Name Of A Class Settings

It's cosmetic? Yes, it of course! But can you back to my first question: What is the purpose of $title attribute?

cyberscribe commented 4 years ago

The menu item is for settings for that object, which corresponds to that data type. So "Some Weird Name Of A Class Settings" is the correct menu item name for "Some Weird Name Of A Class" data.

On Thu, 14 Nov 2019 at 16:35, Rodovalho notifications@github.com wrote:

What is the purpose of $title property? There is no use for that a some cases I don't my menu item called: SomeWeirdNameOfAClass as Some Weird Name Of A Class Settings

It's cosmetic? Yes, it of course! But can you back to my first question: What is the purpose of $title attribute?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tombenner/wp-mvc/pull/249?email_source=notifications&email_token=AAFJLZLUHYUPUJJPF3JORA3QTV44VA5CNFSM4JLVBFA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEECOQJY#issuecomment-553969703, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFJLZJQJSYIR2JQZUI7JC3QTV44VANCNFSM4JLVBFAQ .