tomboy-notes / tomboy.osx

MonoMac-based version of Tomboy.
Other
20 stars 3 forks source link

Notebooks made awesome #24

Closed rashoodkhan closed 10 years ago

rashoodkhan commented 10 years ago

This PR fixes the following issues:

trepidity commented 10 years ago

[DEBUG 21:44:29.054] AppDelegate Handling Note Added New Note 28 Current notebook index is 0 [ERROR 21:44:29.083] Failed to add item from Dock Menu System.NullReferenceException: Object reference not set to an instance of an object at Tomboy.NotesWindowController.HandleNotebookAdded () [0x00007] in /Users/jjennings/Projects/Tomboy/github/tomboy-notes/tomboy.osx/tomboy/NotesWindowController.cs:148 at Tomboy.NotesWindowController.UpdateNotebooksTable () [0x00025] in /Users/jjennings/Projects/Tomboy/github/tomboy-notes/tomboy.osx/tomboy/NotesWindowController.cs:121 at Tomboy.AppDelegate.RefreshNotesWindowController () [0x00024] in /Users/jjennings/Projects/Tomboy/github/tomboy-notes/tomboy.osx/tomboy/AppDelegate.cs:370 at Tomboy.AppDelegate.HandleNoteAdded (Tomboy.Note note) [0x00059] in /Users/jjennings/Projects/Tomboy/github/tomboy-notes/tomboy.osx/tomboy/AppDelegate.cs:289

trepidity commented 10 years ago

Also, I was getting another exception. So I created the following method

    void ReloadNotesTable ()
    {
        if (_notesTableView != null)
            _notesTableView.ReloadData ();
    }
rashoodkhan commented 10 years ago

The first exception is related to the Dock Menu. I will have a look at it once and fix that.

trepidity commented 10 years ago

@rashoodkhan do you want me to merge this PR or are you still working on it?

rashoodkhan commented 10 years ago

Yeah you can merge this one. I am working on Issue #25, but that code update will happen only in the library.

rashoodkhan commented 10 years ago

I will create another PR for the error's generated. I haven't started working on the Dock Menu Error, will finish that work by this weekend.