Closed obilodeau closed 8 years ago
(by trappe) I've done some work in the lp:~trappe/tomdroid/sync-ui branch. It's not all done but you can see where I've been hadded.
(by benoit.garret) Yep, I saw you linked this bug to your branch. I won't have time to take a look at your work this week, but I'll try to check this out this weekend and give you some feedback. Thanks a lot for tackling this!
(by benoit.garret) Sorry for the delay. I played a bit with your code, it looks quite nice and unobstrusive (which is good!).
I have a few nitpick though, from a user perspective as I haven't looked at the code:
You may already be aware of these but I don't know if you're planning to do further work on this, so I'm throwing them here just in case.
And again nice work, I'm really looking forward to merge your work.
(by trappe) Thank you for the review! I just worked on some of your valuable comments.
The sync button in the Actionbar is already deactivated when sync is in progress. I would suggest to remove the sync-menu icon completly in favor for the action bar.
(by benoit.garret) Much better, I can now at least see that something is happening.
I took a quick look at your animation code, but couldn't spot any obvious mistake. I'm afraid I won't be of much help here.
I'm against removing the sync menu icon for two reasons:
Feel free to disagree though ;-) . I may not have completely understood your reasons and I would gladly be proven wrong.
One last thing, I'm curious about the reasons that led you to use a custom notification. There are at least two feedback mechanisms that are already implemented by system applications:
I'm not trying to downplay your work, I'm really, really glad that you stepped up to get in charge of this. I'm just trying to get an understanding of the reasons that led you to your UI choices.
(by trappe) I've now fixed the animation problem and decided to keep the additional sync menu button for now. It was'nt too difficult to make it work correctly.
About your arguments to keep the menu item:
About my decision to use a custom notification:
Using the standard progress bar would mean to have some dedicated UI real estade whre it could be placed. I think it's not worth the space plus it would be decupled from the sync button and hence unclear to the user how synchronisation and a orange bar somewhere else in the UI are related.
Status bar notifications are fine and I think we should implement it sometime. Currently we do not have a background service and I think this a essential precondition.
(by sanfordarmstrong)
On Fri, Jun 11, 2010 at 1:18 AM, Rodja
- Accessibility The menu items are also only accessable via touch. There may be a hardware button to launch the menu, but the menu it self is always represended on the display.
Once the menu button appears, it is accessible via the scroll ball (or whatever navigational hardware is on the device).
(by benoit.garret) If the Google designers say it's allowed, then who am I to question this? ;-) . On a more serious note, I agree with your arguments against the window progress bar. I would say your work is ready to be merged in a very near future, please request a merge when you think your work is finished.
I checked the Twitter app and the item in the ActionBar can be used through the trackball. If you manage to do it in Tomdroid, feel free to remove the menu item as it would remove the last objection I had against this.
(by trappe) Done!
The focus indication could be better, but for now it's good enough. Also there are some glitches when leaving the activity while sync is in progress. This should be fixed by doing the actual sync in a dedicated Android Service which is tracked in #549646.
(by ukev) Hi Rodja,
as in the mailinglist promised, I've tested your code on my nexus one with my ~410 (production) notes and will give you some feedback. I'm really impressed how good it works already.
positive: • Syncronized more than 410 notes in a reasonable time (~10-15 sec. first time sync) • Already really useful, works as expected in all main parts (Hey it does sync my notes to my android phone - really great :)! ) • It didn't delete my notes :)
negative: (only some small fine-tuning related stuff)
Please don't be depressed because my "negative" list has more entrys than my "positive" one. The positive points are the significant ones! Thanks for your code and I'm already pleased to see your next contributions :).
(by trappe) Thanks for testing and the good feedback!
(by obilodeau) Can I mark this as 'fix released'? Can you file valid remaining tasks into separate bugs if any?
Thanks,
(by trappe) Ok. Moved all remaining informations to other bugs. I consider this issue as fixed. The 0.4.1 gets great feedback.
The current code doesn't provide many cues about what's happening behind the scenes and may confuse the user. It could use some work in order to be able to tell the user about the state of the authentication/sync.
It could be divided in two subtasks:
Imported from Launchpad using lp2gh.