tomcatmwi / media-switcher

MediaSwitcher JavaScript class. Allows switching between media streams.
MIT License
4 stars 0 forks source link

Video Resolution of Recording Changes over Time #2

Open lylepratt opened 1 year ago

lylepratt commented 1 year ago

Thank you for making this great library!

I've noticed that the resolution of recorded video seems to incrementally change as the recording progresses. Why is this? Is there a way to force it to start at full resolution?

tomcatmwi commented 1 year ago

Hi,

Glad you liked my kludgings! That degradation seems to be done by the V8 engine itself, and I found no way to control it. You can set the bitrate (and as I recall, I hardcoded the maximum value into the object), but it's ignored for a few seconds after connection. If you happen to figure out a way, please let me know!

Cheers, Tamas

On Fri, Dec 16, 2022 at 12:21 AM Lyle Pratt @.***> wrote:

Thank you for making this great library!

I've noticed that the resolution of recorded video seems to incrementally change as the recording progresses. Why is this? Is there a way to force it to start at full resolution?

— Reply to this email directly, view it on GitHub https://github.com/tomcatmwi/media-switcher/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDPDNNDF5AOU4M6EBCB34LWNORZLANCNFSM6AAAAAATAI3HWM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lylepratt commented 1 year ago

I believe you can influence it by passing these parameters into the SDP from the offering side of a webrtc call: ;x-google-max-bitrate=5000;x-google-min-bitrate=5000;x-google-start-bitrate=5000

Not sure how exactly it would be integrated into this project though.