search

tomchadwin / web2qgis

QGIS webmap scraper
GNU General Public License v2.0
15 stars 2 forks source link

Intermittent failure to import detected map #2

Closed tomchadwin closed 6 years ago

tomchadwin commented 6 years ago

Suspect this could be an async issue: need to await evaluateJavaScript() result (no idea how yet).

tomchadwin commented 6 years ago

Detecting the map seems to work fine, but I'm having problems with detecting the extent. I think I need to separate out the import from the detect. I'll try connecting import to the Save button.

tomchadwin commented 6 years ago

Detect and import now separate, and things do seem to have improved. Will leave open for a bit, awaiting feedback.

hareldunn commented 6 years ago

This url is detected, but crashes repeatedly on 'save', throwing AttributeError: 'NoneType' object has no attribute 'split' image

tomchadwin commented 6 years ago

I thought that issue had called down a bit. It's only where it tries to import the view (ie the extent). For the moment, I'll wrap it in atry: until we can figure out what the underlying fault is.

tomchadwin commented 6 years ago

As far as I can tell, this is not an async issue. The problem arises when the JS executed gives an error, or in any way doesn't give the expected output. I'll close this issue for now, and will open more specific ones as appropriate.