tomchadwin / web2qgis

QGIS webmap scraper
GNU General Public License v2.0
15 stars 2 forks source link

long url #3

Closed mstuyts closed 6 years ago

mstuyts commented 6 years ago

If the url of the webpage is very long only a part of the url is visible in the start screen. Maybe the input box clould grow with the length of the url, or it could be larger (vertical and/or horizontal) so the full url is visible.

web2qgis_long_url

tomchadwin commented 6 years ago

I'd argue that is normal GUI behaviour. A solution might be to have the field expand when you expand the window (not sure how to do that yet).

mstuyts commented 6 years ago

And if you make the field multiline, 3 or 4 lines high with a vertical scroll bar from the start, regardless of the length of the url? The window has some empty space you can use.

tomchadwin commented 6 years ago

I'm not sure. I feel as though a text input for a URL should be one line...

mstuyts commented 6 years ago

No problem, when pasted a long url I first thought the field was limited in the number of characters, because I didn't notice the field split up my url into multiple lines.

tomchadwin commented 6 years ago

I've committed a change so that it stays on one line - it should not have been multiline. Hope it's an improvement.

tomchadwin commented 6 years ago

Apologies - that change was broken. I've now committed the following changes:

I hope that's all behaving as one would expect now?

mstuyts commented 6 years ago

That's much better. I still prefer multi line fields for long texts, but that's a personal preference.

With the QLineEdit object I now get an error message, but for that I'll file a separate bug report.

tomchadwin commented 6 years ago

Thanks for the feedback. I can be persuaded to change my mind about multiline, but I think single line is the right choice at the moment. My guess is that the majority of users will simply copy and paste from their browser address bar.