search

tomchentw / react-google-maps

React.js Google Maps integration component
https://tomchentw.github.io/react-google-maps/
MIT License
4.62k stars 939 forks source link

Fixed react lifecycle methods warning #1001

Closed puviz closed 5 years ago

puviz commented 5 years ago

fix: adding “UNSAFE_” prefix to react lifecycle methods.

JustFly1984 commented 5 years ago

@puviz this library is unmaintained almost 2 years, please refer to new lib npm @react-google-maps/api

puviz commented 5 years ago

@puviz this library is unmaintained almost 2 years, please refer to new lib npm @react-google-maps/api

@JustFly1984 thank you for your suggestion

barrard commented 5 years ago

I ran the command

npx react-codemod rename-unsafe-lifecycles

to fix this issure, but im still getting the warnings. How did you accomplish this? thanks.

JustFly1984 commented 5 years ago

@barrard this library is unmaintained more than two years and will never be updated. Please refer to our rewrote and updated version: @react-google-maps/api

barrard commented 5 years ago

@JustFly1984 Thanks for your work on this new library. It seems to be missing MarkerWithLabel which I want to use.

JustFly1984 commented 5 years ago

@barrard If you need it, your PR is welcome, you can create a new package in our repo, and I will publish it and update the main library, just copy marker-clusterer, and replace the code inside the copy