Showing componentWillMount deprecated warnings .

tomchentw / react-google-maps

React.js Google Maps integration component

https://tomchentw.github.io/react-google-maps/

MIT License

4.62k stars 939 forks source link

Showing componentWillMount deprecated warnings . #1002

Open vineet-agrawal96 opened 4 years ago

vineet-agrawal96 commented 4 years ago

How to fix this following warnings. I'm sure we are not using anywhere componentWillMount method in our project.

breadcrumbs.js:76 Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

Move code with side effects to componentDidMount, and set initial state in the constructor.
Rename componentWillMount to UNSAFEcomponentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: withGoogleMap(Component)

JustFly1984 commented 4 years ago

this project is unmaintained more than a year, please look at @react-google-maps/api

KevinBurton commented 4 years ago

Is there a similar React component that is more actively maintained?

JustFly1984 commented 4 years ago

@KevinBurton The repo of this project is unmaintained more than a year, and we had build new version https://www.npmjs.com/package/@react-google-maps/api

We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api You can enjoy autocomplete.

You can see our docs: https://react-google-maps-api-docs.netlify.com/

Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.com/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples

The bundle size is much smaller: https://bundlephobia.com/result?p=@react-google-maps/api@1.7.7

Our Spectrum community: https://spectrum.chat/react-google-maps

Enjoy! 

NitnekB commented 4 years ago

Hello!

Thanks for those informations @JustFly1984 Nevertheless, it was too late for me when I discovered this project is no longer maintain :S Can I suggest to add this precious information directly on README?

I already prepared a PR for this: https://github.com/tomchentw/react-google-maps/pull/1028

Many thanks!

JustFly1984 commented 4 years ago

@NitnekB it is not possible to add PR, cos PR could be merged only by owner, who disagreed 2 years ago. Your PR is useless, nobody can't merge it. Consider to switch to my library.

NitnekB commented 4 years ago

Good to know, thx!

Too bad for this though. Other people will probably make the same mistake.. 😕

Anyway, thank you for your lib 👍