tomchentw / react-google-maps

React.js Google Maps integration component
https://tomchentw.github.io/react-google-maps/
MIT License
4.62k stars 939 forks source link

KML Layer from AWS S3 not added #1053

Open lysaan opened 3 years ago

lysaan commented 3 years ago

Hi, thanks for this wonderful package. It is very helpful. There is one little improvement which could be very useful.

<KmlLayer 
         url='https://maps.s3.ap-southeast-2.amazonaws.com/kml_maps/new_kml.kml?X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=XXX_request&X-Amz-Date=20200812T052139Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Signature=XXX'
        options={{ preserveViewport : true}}
    />

It is working fine if Object is public on AWS S3 but not working when generating Presigned URL for S3 objects.

If you could check it out then it would be great.

Thanks

JustFly1984 commented 3 years ago

@lysaan The repo of this project is unmaintained more than 3 years, and we had build new version https://www.npmjs.com/package/@react-google-maps/api

We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api You can enjoy autocomplete.

You can see our docs: https://react-google-maps-api-docs.netlify.app

Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.app/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples

The bundle size is much smaller: https://bundlephobia.com/result?p=@react-google-maps/api

Our Spectrum community: https://spectrum.chat/react-google-maps
Our Slack channel: https://join.slack.com/t/react-google-maps-api/shared_invite/enQtODc5ODU1NTY5MzQ4LTBiNTYzZmY1YmVjYzJhZThkMGU0YzUwZjJkNGJmYjk4YjQyYjZhMDk2YThlZGEzNDc0M2RhNjBmMWE4ZTJiMjQ

Enjoy!

lysaan commented 3 years ago

Ok thanks, but we were able to solve this issue. You just need to replace '&' with '& a m p ; (without spaces)'. Thanks 😊