search

tomchentw / react-toastr

React.js toastr component
https://tomchentw.github.io/react-toastr/
MIT License
619 stars 112 forks source link

Version 2.6.0 introduces a breaking change #49

Closed JamieDixon closed 8 years ago

JamieDixon commented 8 years ago

Since the 2.6.0 release, React 15 is required.

This broke our codebase because 2.6.0 introduces a breaking change and our match for "^2.4.0" allowed for 2.6.0 to be installed without warning.

Since 2.6.0 introduces this breaking change I suggest the version be bumped to the next major version, 3.0 in line with semver.

What do you think? Thanks for react-toastr, we really appreciate all your work on this library!

jerairrest commented 8 years ago

I agree!

tomchentw commented 8 years ago

Apologies for that. I didn't review carefully when merging PR #48. How about change it to:

    "react": "^0.14.0 || ^15.0.0",
    "react-dom": "^0.14.0 || ^15.0.0"
tomchentw commented 8 years ago
JamieDixon commented 8 years ago

Thanks Tom. Much appreciated. Be well.