search

tomchentw / react-toastr

React.js toastr component
https://tomchentw.github.io/react-toastr/
MIT License
619 stars 112 forks source link

feat(preventDuplicates): Changed to list #60

Closed RangarajKaushikSundar closed 8 years ago

RangarajKaushikSundar commented 8 years ago

The prevent duplicates feature works by checking the previously rendered message with the current message and avoids duplicates. There is a test case which will not pass in the following situation - success('hello') --- followed by --> success('bye') --- followed by--> success('hello'). The last "hello" should not render until the previous "hello" has unmounted.

Now, the code maintains a list of messages that are currently being rendered. This makes sure that aforementioned issue doesn't happen.

RangarajKaushikSundar commented 8 years ago

@tomchentw The previous pull request helps us avoid the duplicate messages. Kindly approve this pull request since it completes the functionality.

tomchentw commented 8 years ago

@RangarajKaushikSundar I'd like to invite you to be a collaborator of this project. Are you interested?

RangarajKaushikSundar commented 8 years ago

@tomchentw I would be happy to.

tomchentw commented 8 years ago

Released v2.8.0

tomchentw commented 8 years ago

@RangarajKaushikSundar invited!