tomchentw / react-toastr

React.js toastr component
https://tomchentw.github.io/react-toastr/
MIT License
619 stars 112 forks source link

Fixes #63 : Do not propagate component specific props to div #67

Closed abalhier closed 8 years ago

abalhier commented 8 years ago

See issue https://github.com/Hacker0x01/react-datepicker/issues/517 and Dan Abramov (gaearon) comments

abalhier commented 8 years ago

I used pick in my first version of the pull request. But by using lodash omit, it allows to propagate className and style and other props which maybe supported by a div.

tomchentw commented 8 years ago

@abalhier thanks! This looks great. Just one more thing: could you revert your changes of lib folder in this branch? They should be automatically generated by the release script, thanks!

abalhier commented 8 years ago

Done ! :)

tomchentw commented 8 years ago

Released v2.8.0