issues with packaging: react-dom

[chalda]

Hi, We are using react-bootstrap-table in our project and recently started running into bundling issues. Our react (and subsequently react-dom and react-addons-..) are pegged at 15.3.0 for compatibility reasons. While packaging some sub-components we started noticing errors with react dependancies coming from react-toastr which is installed by react-boostrap-table.

Specifically I think this bit in your package.json installs react-dom explicitly: "peerDependencies": { "react": "^0.14.0 || ^15.0.0" }, "dependencies": { "classnames": "^2.2.5", "element-class": "^0.2.2", "lodash": "^4.16.1", "react-addons-update": "^0.14.0 || ^15.0.0", "react-dom": "^0.14.0 || ^15.0.0" }

This bit installs the LATEST react-dom (15.4.0 at the time of writing), skips react as well it should, and then breaks when react@15.4.0 is missing. The versions of react, react-dom and react-addons have to match exactly.

we get npm warnings such as: npm WARN react-addons-update@15.4.0 requires a peer of react@^15.4.0 but none was installed. ├─┬ react-bootstrap-table@2.5.8 │ ├── classnames@2.2.5 │ └─┬ react-toastr@2.8.2 │   ├── element-class@0.2.2 │   ├── UNMET PEER DEPENDENCY react@^15.4.0 │   └── react-addons-update@15.4.0

and our build fails when certain libs from react are missing. Specifically ReactComponentTreeHook. This got renamed in 15.3.1 and above. See here: https://fossies.org/diffs/react/15.3.0-src_vs_15.3.1-src/src/renderers/shared/ReactDebugTool.js-diff.html

I am not 100% confident this is an issue with react-toastr or react-bootstrap-table but this is where my digging lead me. Any thoughts/advice?

[chalda]

cc: @bojangles495

[chalda]

sorry seems to be a possible duplicate of #33 still an issue never the less