search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 8 forks source link

Update Oceananigans #107

Closed tomchor closed 1 year ago

tomchor commented 1 year ago

The calc_νᶜᶜᶜ method don't exist anymore and should be changed to calc_nonlinear_νᶜᶜᶜ.

tomchor commented 1 year ago

This PR is a bit ugly and it overlaps a bit with https://github.com/tomchor/Oceanostics.jl/pull/97, but I'd like to merge this now to have Oceanostics compatible with the most recentl Oceananigans version.

https://github.com/tomchor/Oceanostics.jl/pull/97 is significantly more complicated (due to the tracer budget) and I probably won't have time to get to it in a little while unfortunately...

tomchor commented 1 year ago

Can’t really check the changes. Are they covered by tests?

Yes! They're covered by this test: https://github.com/tomchor/Oceanostics.jl/blob/da77a609eb58cc83b46a7d0f2260e9f3f6a3a7f5/test/runtests.jl#L153-L163