search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 8 forks source link

Upgrade to Julia v1.9 and Oceananigans v0.86 #145

Closed github-actions[bot] closed 11 months ago

github-actions[bot] commented 11 months ago

This PR upgrade to Julia v1.9 and Oceananigans v0.86. (edited)

tomchor commented 11 months ago

Docs build is failing with

ERROR: LoadError: ArgumentError: Package NetCDF_jll [7243133f-43d8-5620-bbf4-c2c921802cf3] is required but does not seem to be installed:
 - Run `Pkg.instantiate()` to install all recorded dependencies.

Not sure what's happening. This builds fine locally in 1.9.2.

tomchor commented 11 months ago

@navidcy do you have any idea of what's happening? I'm getting a message on "Build and deploy" that NetCDF_jll doesn't seem to be installed. Yet I can see it being installed in the "Install dependencies" part. This is compiling fine locally...

navidcy commented 11 months ago

I don't really know... but opened #147 which supersedes this.

Would you still like to work on this?

navidcy commented 11 months ago

oh now I noticed that Julia v1.9 was included here! I was confused with the PR title -- sorry.

tomchor commented 11 months ago

oh now I noticed that Julia v1.9 was included here! I was confused with the PR title -- sorry.

yeah, sorry I hadn't changed the PR title from the original title opened by the Compat helper!

navidcy commented 11 months ago

Me also don't understand what the issue is with NetCDF_jll btw!

navidcy commented 11 months ago

I made a last attempt to avoid Pkg.develop() and enforce using the Manifest.toml of the main repo (similarly to what we do in Oceananigans) -- let's see.

navidcy commented 11 months ago

Btw, I made a few other fixes. (Just a note in case this PR never gets merged for one reason or another..)

navidcy commented 11 months ago

this seems to have worked ;)

tomchor commented 11 months ago

this seems to have worked ;)

That's awesome, thanks @navidcy! Do you understand why this worked? Because I don't haha