Everything compiled and ran locally, including the tests, but there is an issue with precompiling Oceananigans.jl and Oceanostics.jl (see message below) on ci. I have a branch where I am looking into this.
ERROR: The following 2 direct dependencies failed to precompile:
Oceananigans [9e8cae18-63c1-5223-a75c-80ca9d6e9a09]
Failed to precompile Oceananigans [9e8cae18-63c1-5223-a75c-80ca9d6e9a09] to "/home/runner/.julia/compiled/v1.9/Oceananigans/jl_x15NUq".
ERROR: LoadError: error in method definition: function Architectures.on_architecture must be explicitly imported to be extended
Stacktrace:
[1] top-level scope
@ none:0
[2] top-level scope
@ ~/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/conditional_operations.jl:137
[3] include(mod::Module, _path::String)
@ Base ./Base.jl:457
[4] include(x::String)
@ Oceananigans.AbstractOperations ~/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/AbstractOperations.jl:1
[5] top-level scope
@ ~/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/AbstractOperations.jl:70
[6] include(mod::Module, _path::String)
@ Base ./Base.jl:457
[7] include(x::String)
@ Oceananigans ~/.julia/packages/Oceananigans/ctYdG/src/Oceananigans.jl:5
[8] top-level scope
@ ~/.julia/packages/Oceananigans/ctYdG/src/Oceananigans.jl:205
[9] include
@ ./Base.jl:457 [inlined]
[10] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
@ Base ./loading.jl:2049
[11] top-level scope
@ stdin:3
in expression starting at /home/runner/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/conditional_operations.jl:137
in expression starting at /home/runner/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/AbstractOperations.jl:1
in expression starting at /home/runner/.julia/packages/Oceananigans/ctYdG/src/Oceananigans.jl:1
in expression starting at stdin:3
Oceanostics [d0ccf[422](https://github.com/tomchor/Oceanostics.jl/actions/runs/8414347118/job/23037881751#step:6:425)-c8fb-49b5-a76d-74acdde946ac]
Failed to precompile Oceanostics [d0ccf422-c8fb-49b5-a76d-74acdde946ac] to "/home/runner/.julia/compiled/v1.9/Oceanostics/jl_utTV51".
ERROR: LoadError: error in method definition: function Architectures.on_architecture must be explicitly imported to be extended
Stacktrace:
[1] top-level scope
@ none:0
[2] top-level scope
@ ~/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/conditional_operations.jl:137
[3] include(mod::Module, _path::String)
@ Base ./Base.jl:457
[4] include(x::String)
@ Oceananigans.AbstractOperations ~/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/AbstractOperations.jl:1
[5] top-level scope
@ ~/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/AbstractOperations.jl:70
[6] include(mod::Module, _path::String)
@ Base ./Base.jl:457
[7] include(x::String)
@ Oceananigans ~/.julia/packages/Oceananigans/ctYdG/src/Oceananigans.jl:5
[8] top-level scope
@ ~/.julia/packages/Oceananigans/ctYdG/src/Oceananigans.jl:205
[9] include
@ ./Base.jl:457 [inlined]
[10] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
@ Base ./loading.jl:2049
[11] top-level scope
@ stdin:3
in expression starting at /home/runner/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/conditional_operations.jl:137
in expression starting at /home/runner/.julia/packages/Oceananigans/ctYdG/src/AbstractOperations/AbstractOperations.jl:1
in expression starting at /home/runner/.julia/packages/Oceananigans/ctYdG/src/Oceananigans.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile Oceananigans [9e8cae18-63c1-5223-a75c-80ca9d6e9a09] to "/home/runner/.julia/compiled/v1.9/Oceananigans/jl_ReaFuc".
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:35
[2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
@ Base ./loading.jl:2294
[3] compilecache
@ ./loading.jl:2167 [inlined]
[4] _require(pkg::Base.PkgId, env::String)
@ Base ./loading.jl:1805
[5] _require_prelocked(uuidkey::Base.PkgId, env::String)
@ Base ./loading.jl:1660
[6] macro expansion
@ ./loading.jl:1648 [inlined]
[7] macro expansion
@ ./lock.jl:267 [inlined]
[8] require(into::Module, mod::Symbol)
@ Base ./loading.jl:1611
[9] include
@ ./Base.jl:457 [inlined]
[10] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
@ Base ./loading.jl:2049
[11] top-level scope
@ stdin:3
in expression starting at /home/runner/work/Oceanostics.jl/Oceanostics.jl/src/Oceanostics.jl:1
in expression starting at stdin:3
Everything compiled and ran locally, including the tests, but there is an issue with precompiling Oceananigans.jl and Oceanostics.jl (see message below) on ci. I have a branch where I am looking into this.