search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 9 forks source link

Including a fancier progress messenger #23

Closed tomchor closed 3 years ago

tomchor commented 3 years ago

@glwagner @ali-ramadhan Would you be opposed that I copy this very useful progress messenger to Oceanostics.jl?

The rationale is that I think the wall_time_per_step feature is super-useful, but currently it only works for LES (since it's in LESbrary). I'd like to make a version of it here that works for both (kinda like what I did here).

After that you can even delete that progress messenger from LESbrary and use the one from Oceanostics.

Thoughts?

glwagner commented 3 years ago

Seems legit. Or maybe it belongs in Oceananigans?

tomchor commented 3 years ago

We can discuss this further or take a vote with other contributors, but I think Oceananigans is a pretty big package already. So my tendency has been to try to not add more stuff to it unless necessary.

So for example, I was thinking of adding utilities stuff like progress messengers, sponge layers, to other packages. I think Oceanostics is a good candidate.